Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

results from IBM compiler: #333

Closed

Conversation

awierzch
Copy link

@awierzch awierzch commented Jul 7, 2021

Description

This code is based on https://github.com/PlummersSoftwareLLC/Primes/tree/drag-race/PrimeCOBOL/solution_1.

I took the above code and made some minor changes to properly compile and run it on a real mainframe.

Contributing requirements

  • I read the contribution guidelines in CONTRIBUTING.md.
  • I placed my solution in the correct solution folder.
  • I added a README.md with the right badge(s).
  • I added a Dockerfile that builds and runs my solution.
  • I selected drag-race as the target branch.
  • All code herein is licensed compatible with BSD-3.

@rbergen
Copy link
Contributor

rbergen commented Jul 7, 2021

As much as I am genuinely charmed by this, I don't think we can merge it into the solution tree. Not mentioning some smaller technicalities, the main problem is that we have no IBM mainframe to run the benchmarks on. We're now at a point where we really can't merge anything new that we can't include in the benchmark.

May I suggest to open a "show and tell" post in Discussions, and post this there?

@rbergen
Copy link
Contributor

rbergen commented Jul 7, 2021

Tagging @fvbakel. I imagine you'll like this, too :)

@fvbakel
Copy link
Contributor

fvbakel commented Jul 8, 2021

@rbergen Thanks for mentioning this!

@awierzch Great that you took the effort for the IBM compile, I don't have access to such hardware. I did notice that the time is 50 in your output. Is there a dot missing?

@rbergen
Copy link
Contributor

rbergen commented Jul 8, 2021

It seems GitHub lacks at least one feature, being the ability to convert a PR into a show and tell Discussions post...
Be that as it may, I will have to close this.

@rbergen rbergen closed this Jul 8, 2021
@awierzch
Copy link
Author

awierzch commented Jul 9, 2021

As much as I am genuinely charmed by this, I don't think we can merge it into the solution tree. Not mentioning some smaller technicalities, the main problem is that we have no IBM mainframe to run the benchmarks on. We're now at a point where we really can't merge anything new that we can't include in the benchmark.

No problem, just wanted to share my results and compare GNU compiler on PC with IBM compiler on mainframe.

@awierzch
Copy link
Author

awierzch commented Jul 9, 2021

@rbergen Thanks for mentioning this!

@awierzch Great that you took the effort for the IBM compile, I don't have access to such hardware. I did notice that the time is 50 in your output. Is there a dot missing?

Yes. I was too lazy to fix this.

@andrew890
Copy link

I have been putting together some specific IBM mainframe z/OS adaptations so I have included the changes in that:
https://github.com/andrew890/Primes-zOS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants