Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change SPIFF web server to serve static linked files #212

Merged
merged 50 commits into from
Feb 5, 2023

Conversation

Louis-Riel
Copy link
Contributor

Description

  • Removed SPIFF functionality from CSPIFFWebWebServer and renamed to CWebServer
  • Updated platformio.ini to add the DCOMPONENT_EMBED_TXTFILES directives for the CWebSerer
  • Updated platformio.ini with extra_scripts trigger to build the web site
  • Added /site to contain the source of the web site

Contributing requirements

  • I read the contribution guidelines in CONTRIBUTING.md.
  • I understand the BlinkenPerBit metric, and maximized it in this PR.
  • I selected main as the target branch.
  • All code herein is subjected to the license terms in COPYING.txt.

@davepl
Copy link
Contributor

davepl commented Feb 3, 2023 via email

@rbergen
Copy link
Collaborator

rbergen commented Feb 4, 2023

Just to check: does this PR create to a non-SPIFF webserver implementation that is already functionally equivalent to the one that is currently in the codebase?

@Louis-Riel
Copy link
Contributor Author

Louis-Riel commented Feb 4, 2023

Correct. The web server is the same impl. The spiff initialization and deinit are removed, and the spiff space is reallocated to the main flash. This is the released feature more than the skeleton site itself.

The web server no longer tries to resolve web requests through filesystem queries, replacing that with 2 explicit end points, one for the html, one for the JavaScript. There will be a third EP added for favicon eventually, once we SVG a logo.

@rbergen rbergen merged commit eecd11f into PlummersSoftwareLLC:main Feb 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants