Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add autosaving to the editor #688

Merged
merged 6 commits into from
Nov 2, 2019

Conversation

epsilon-phase
Copy link
Contributor

This should fix #686 Confirmation prior to navigating away is easy enough to add, but it'd be good to know if it's wanted first since this seems like it might serve the same purpose

@codecov
Copy link

codecov bot commented Oct 31, 2019

Codecov Report

Merging #688 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #688   +/-   ##
=======================================
  Coverage   39.35%   39.35%           
=======================================
  Files          72       72           
  Lines        9494     9494           
  Branches     2263     2263           
=======================================
  Hits         3736     3736           
  Misses       4702     4702           
  Partials     1056     1056

Copy link
Contributor

@trinity-1686a trinity-1686a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

plume-front/src/editor.rs Outdated Show resolved Hide resolved
plume-front/src/editor.rs Outdated Show resolved Hide resolved
Copy link
Member

@elegaanz elegaanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't tested yet, but I left a few comments about the code itself.

plume-front/src/editor.rs Outdated Show resolved Hide resolved
plume-front/src/editor.rs Outdated Show resolved Hide resolved
plume-front/src/editor.rs Outdated Show resolved Hide resolved
plume-front/src/editor.rs Outdated Show resolved Hide resolved
plume-front/src/editor.rs Outdated Show resolved Hide resolved
Copy link
Member

@elegaanz elegaanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected, thank you!

@elegaanz elegaanz merged commit c0469c6 into Plume-org:master Nov 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

warn when leaving edit page with unsaved change
3 participants