Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

order media so that latest added are top #660

Merged
merged 2 commits into from
Aug 28, 2019
Merged

order media so that latest added are top #660

merged 2 commits into from
Aug 28, 2019

Conversation

trinity-1686a
Copy link
Contributor

partial fix for #621

@trinity-1686a trinity-1686a added C: Enhancement New feature or request A: Front-End Related to the front-end S: Ready for review This PR is ready to be reviewed labels Aug 27, 2019
@codecov
Copy link

codecov bot commented Aug 27, 2019 •
edited
Loading

Codecov Report

Merging #660 into master will increase coverage by 0.04%.
The diff coverage is 85.71%.

@@            Coverage Diff             @@
##           master     #660      +/-   ##
==========================================
+ Coverage   35.11%   35.15%   +0.04%     
==========================================
  Files          68       68              
  Lines        7943     7950       +7     
  Branches     1889     1889              
==========================================
+ Hits         2789     2795       +6     
- Misses       4374     4375       +1     
  Partials      780      780

igalic
igalic reviewed Aug 27, 2019
View reviewed changes
Copy link
Contributor

@igalic igalic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓

plume-models/src/medias.rs Show resolved Hide resolved
elegaanz
elegaanz previously requested changes Aug 27, 2019
View reviewed changes
Copy link
Member

@elegaanz elegaanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally, it should be done for the paginated version too, so that /media lists them in the correct order.

igalic
igalic approved these changes Aug 28, 2019
View reviewed changes
Copy link
Contributor

@igalic igalic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@elegaanz elegaanz dismissed their stale review August 28, 2019 09:36

It have been fixed.

@elegaanz elegaanz merged commit d46af6f into master Aug 28, 2019
@elegaanz elegaanz deleted the feature/621 branch August 28, 2019 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igalic igalic igalic approved these changes

@elegaanz elegaanz elegaanz left review comments

Assignees
No one assigned
Labels
A: Front-End Related to the front-end C: Enhancement New feature or request S: Ready for review This PR is ready to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@trinity-1686a @igalic @elegaanz