delete notification on user deletion #658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trinity-1686a
added
C: Bug
trinity-1686a
force-pushed
the
bugfix/651
branch
from
4b640ee
to
bed9a12
Compare
Codecov Report
@@ Coverage Diff @@
## master #658 +/- ##
==========================================
+ Coverage 34.58% 35.17% +0.58%
==========================================
Files 68 68
Lines 8020 7952 -68
Branches 1890 1893 +3
==========================================
+ Hits 2774 2797 +23
+ Misses 4468 4374 -94
- Partials 778 781 +3 |
elegaanz
requested changes
Aug 27, 2019
elegaanz
previously approved these changes
Aug 28, 2019
trinity-1686a
force-pushed
the
bugfix/651
branch
from
b6f5eab
to
1b0c2fa
Compare
|
this has been stall for a bit, and I don't have time to fix the CI (the problem is not related to the fix, but to the way integration tests are run). I'll revert latests commit so we can merge it as is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #651
before merging, I'd like to add a regression test