Update textarea overflow to scroll #609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #609 +/- ##
=========================================
+ Coverage 34.56% 34.6% +0.03%
=========================================
Files 67 67
Lines 7840 7840
Branches 1883 1883
=========================================
+ Hits 2710 2713 +3
Misses 4367 4367
+ Partials 763 760 -3 |
elegaanz
previously approved these changes
Jun 2, 2019
It does... I mean testing it live would probably be a good idea still, but there's really no reason why it should cause any problems. Pretty basic stuff overall... |
elegaanz
reviewed
Jun 2, 2019
static/css/_forms.scss
Outdated
| @@ -114,6 +114,7 @@ input[type="submit"] { | |||
| // Writing page | |||
| form.new-post { | |||
| max-width: 60em; | |||
| overflow-y: scroll; | |||
There was a problem hiding this comment.
This line should be removed, otherwise there is a weird and useless scrollbar on the right of the whole form:
|
Right. Done. |
elegaanz
approved these changes
Jun 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial fix for #604.