-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Confirm deletion of blog #602
Confirm deletion of blog #602
Conversation
Not sure why the CI is failing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello and thanks for your PR! Don't hesitate to change the message if you feel to do so, having one more string to translate is not a problem at all.
And the reason the CI fails is that it takes a lot of memory to compile Plume, and sometimes Circle CI containers just don't give us enough… so Rust is killed by the OOM-killer (so nothing to do with your code, it may work next time).
Otherwise, it works just fine. Thank you again!
Thanks! Looking at the previous commits, would you recommend going on Crowdin directly to generate new translations? I’ll play with this further tomorrow. |
You don't need to go on Crowdin to add translations: any string written in the |
Codecov Report
@@ Coverage Diff @@
## master #602 +/- ##
=========================================
+ Coverage 34.54% 34.6% +0.06%
=========================================
Files 67 67
Lines 7825 7840 +15
Branches 1881 1883 +2
=========================================
+ Hits 2703 2713 +10
- Misses 4361 4367 +6
+ Partials 761 760 -1 |
Oh nice 😃 In that case I've updated this PR, and opened another to clarify the docs. |
Thank you again! |
Closes #601.
Ideally I'd like a less generic confirmation message - Are you sure you want to permanently delete this blog?. But assuming this won't be possible without new translations, I feel that it's probably not worth it. Thoughts welcome.