rewrite circleci config #558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
trinity-1686a
commented
May 1, 2019
•
trinity-1686a
commented
- use better syntax
- grcov for coverage
- automatize crowdin interactions
trinity-1686a
added
S: Incomplete
and try using grcov for coverage
elegaanz
reviewed
May 1, 2019
| @@ -1,3 +1,3 @@ | |||
| [target.x86_64-unknown-linux-gnu] | |||
| # link dead code for coverage, attempt to reduce linking memory usage to not get killed | |||
| rustflags = ["-Clink-dead-code", "-Clink-args=-Xlinker --no-keep-memory -Xlinker --reduce-memory-overheads"] | |||
| rustflags = ["-Clink-args=-Xlinker --no-keep-memory -Xlinker --reduce-memory-overheads"] | |||
There was a problem hiding this comment.
Don't we need to link dead code anymore?
There was a problem hiding this comment.
It's somewhere it this line now https://github.com/Plume-org/Plume/pull/558/files#diff-1d37e48f9ceff6d8030570cd36286a61R74 , and having that here was an error : release builds were run with linked dead code too (not a problem, but it makes for bigger binaries)
elegaanz
reviewed
May 1, 2019
Codecov Report
@@ Coverage Diff @@
## master #558 +/- ##
==========================================
- Coverage 41.96% 35.05% -6.91%
==========================================
Files 70 67 -3
Lines 8839 7825 -1014
Branches 0 1876 +1876
==========================================
- Hits 3709 2743 -966
+ Misses 5130 4323 -807
- Partials 0 759 +759 |
trinity-1686a
added
S: Ready for review
elegaanz
approved these changes
May 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.