Make comments in styleshhets a bit clearer #545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #545 +/- ##
=======================================
Coverage 43.97% 43.97%
=======================================
Files 68 68
Lines 7890 7890
=======================================
Hits 3470 3470
Misses 4420 4420 |
igalic
approved these changes
Apr 24, 2019
| @@ -1,4 +1,4 @@ | |||
| // Colors | |||
| // Color Scheme | |||
There was a problem hiding this comment.
how did this change, in its own, fail the build?
There was a problem hiding this comment.
kcov seems to use something that is not always available in circle-ci containers, and make the job fail with a "set personality failed" or similar. When I see one, I usually restart the workflow to make things pass as they should, in this case I wasn't quick enough and you noticed before me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.