-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Editor improvements #486
Editor improvements #486
Conversation
- Make it possible to insert new paragraphs in the article body - Make it impossible to copy formatted HTML (to make media insertion from markdown code work correctly)
If I may add to the todo list: #458 (comment) |
Codecov Report
@@ Coverage Diff @@
## master #486 +/- ##
==========================================
- Coverage 26.83% 24.56% -2.27%
==========================================
Files 65 65
Lines 9000 7116 -1884
==========================================
- Hits 2415 1748 -667
+ Misses 6585 5368 -1217 |
@fdb-hiroshima Yes, the first one is already fixed, I'll see for the other. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a bit sad markdown does not work with the rich editor (cmark see some div so it assumes it's only html and does not attempt to parse markdown)
@fdb-hiroshima This should definitely be fixed before merging this branch I think. I will see what I can do. |
The only fix I see is, given the following : <div>some text</div><div>![desc](path/to/picture.png)</div> Where we are given a single |
I was more thinking of pre-processing the HTML with the DOM APIs in WASM, because your solution may break footnotes, or links that use this syntax:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please remove the callgrind output files from the PR
TODO: