Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor improvements #486

Merged
merged 14 commits into from
Apr 6, 2019
Merged

Editor improvements #486

merged 14 commits into from
Apr 6, 2019

Conversation

elegaanz
Copy link
Member

@elegaanz elegaanz commented Mar 16, 2019

  • Make it possible to insert new paragraphs in the article body
  • Make it impossible to copy formatted HTML (to make media insertion from markdown code work correctly)

TODO:

  • make it possible to escape draft mode
  • display errors from the server
  • button to go back to the "normal" editor
  • Avoid publishing placeholders

- Make it possible to insert new paragraphs in the article body
- Make it impossible to copy formatted HTML (to make media insertion from markdown code work correctly)
@elegaanz elegaanz added C: Enhancement New feature or request A: Front-End Related to the front-end labels Mar 16, 2019
@trinity-1686a
Copy link
Contributor

If I may add to the todo list: #458 (comment)

@codecov
Copy link

codecov bot commented Mar 16, 2019

Codecov Report

Merging #486 into master will decrease coverage by 2.26%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #486      +/-   ##
==========================================
- Coverage   26.83%   24.56%   -2.27%     
==========================================
  Files          65       65              
  Lines        9000     7116    -1884     
==========================================
- Hits         2415     1748     -667     
+ Misses       6585     5368    -1217

@elegaanz
Copy link
Member Author

@fdb-hiroshima Yes, the first one is already fixed, I'll see for the other. :)

@elegaanz elegaanz marked this pull request as ready for review March 17, 2019 13:00
@trinity-1686a trinity-1686a added the S: Ready for review This PR is ready to be reviewed label Mar 18, 2019
plume-front/src/editor.rs Outdated Show resolved Hide resolved
trinity-1686a
trinity-1686a previously approved these changes Mar 27, 2019
Copy link
Contributor

@trinity-1686a trinity-1686a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a bit sad markdown does not work with the rich editor (cmark see some div so it assumes it's only html and does not attempt to parse markdown)

@elegaanz
Copy link
Member Author

@fdb-hiroshima This should definitely be fixed before merging this branch I think. I will see what I can do.

@trinity-1686a
Copy link
Contributor

The only fix I see is, given the following :

<div>some text</div><div>![desc](path/to/picture.png)</div>

Where we are given a single Html("<div>some text</div><div>![desc](path/to/picture.png)</div>"), we could cut it out as ["some text", "![desc](path/to/picture.png)"], call cmark on each of these, and put back the divs

@elegaanz
Copy link
Member Author

I was more thinking of pre-processing the HTML with the DOM APIs in WASM, because your solution may break footnotes, or links that use this syntax:

my [link]

[link]: https://example.org

igalic
igalic previously requested changes Mar 27, 2019
Copy link
Contributor

@igalic igalic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove the callgrind output files from the PR

@elegaanz elegaanz dismissed igalic’s stale review March 28, 2019 06:48

Callgrind files have been removed

@elegaanz elegaanz merged commit 1f7ff62 into master Apr 6, 2019
@elegaanz elegaanz deleted the editor-improvements branch April 6, 2019 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: Front-End Related to the front-end C: Enhancement New feature or request S: Ready for review This PR is ready to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants