Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No theme at all on "Default theme" #701

Closed
Kekun opened this issue Nov 24, 2019 · 7 comments · Fixed by #746
Closed

No theme at all on "Default theme" #701

Kekun opened this issue Nov 24, 2019 · 7 comments · Fixed by #746
Labels
C: Bug Something isn't working Rendering How elements're rendered out for the end user

Comments

@Kekun
Copy link

Kekun commented Nov 24, 2019

I had the light theme, I modified my profile, the theme was "Default theme" and I didn't touch the combobox at all, I saved my changes, I had no theme.

When explicitly setting another theme, it works, when explicitely setting it back to "Default theme", I have no theme again.

Capture d’écran de 2019-11-24 19-17-55

  • Plume version: 0.3.0
  • Operating system: Fedora Silverblue 31.20191107.0
  • Web Browser: GNOME Web 3.34.0-18-g574f7196c (current nightly)
@Kekun Kekun added the C: Bug Something isn't working label Nov 24, 2019
@marek-lach marek-lach added the Rendering How elements're rendered out for the end user label Dec 8, 2019
@marek-lach
Copy link
Member

For context: https://bugs.launchpad.net/ubuntu/+source/epiphany-browser/+bug/173147

@elegaanz
Copy link
Member

elegaanz commented Dec 9, 2019

If this bug doesn't come from Plume but from GNOME Web, I'm closing this issue. If someone can reproduce with another browser/engine, I will reopen it.

@elegaanz elegaanz closed this as completed Dec 9, 2019
@Kekun
Copy link
Author

Kekun commented Dec 10, 2019

The issue you refer to is:

  • not on GNOME Web's bug tracker but on Ubuntu's,
  • 12 years old,
  • closed as invalid since more than 9 years.

And here is a screenshot of the same issue repeated with the very same steps in Firefox 70.0 as packaged in Fedora 31.

Capture d’écran de 2019-12-10 09-18-47

@elegaanz
Copy link
Member

Ok, sorry you are right, I'm reopening.

@elegaanz elegaanz reopened this Dec 10, 2019
@Kekun
Copy link
Author

Kekun commented Dec 10, 2019

Thanks! :)

@marek-lach
Copy link
Member

Very generic things that may, (or may not) help:

  • Declaring the type="text/css" explicitly, linking to the theme's scss files
  • Edit comments in stylesheets from // format to /* ... */

@marek-lach marek-lach mentioned this issue Dec 16, 2019
Merged
@KitaitiMakoto KitaitiMakoto mentioned this issue Apr 12, 2020
Merged
elegaanz pushed a commit that referenced this issue Apr 12, 2020
@KitaitiMakoto
Fix #701 Preferable default theme (#746)
b834d1c 
* Make it possible to update users.preferred_theme to NULL

* Make preferred them null when 'Default theme' is selected

* Run cargo fmt
@verymilan
Copy link

It would be amazing to put a new release out, even if only for this, as it confuses the users quite a lot...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C: Bug Something isn't working Rendering How elements're rendered out for the end user
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #701 Preferable default theme KitaitiMakoto/Plume
4 participants
@Kekun @verymilan @elegaanz @marek-lach