Skip to content

php8 fix for str replace #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

php8 fix for str replace #19

wants to merge 2 commits into from

Conversation

@kjmnavarro
Copy link

No description provided.

@kjmnavarro kjmnavarro requested a review from ebakernz November 9, 2022 02:22
ebakernz
ebakernz reviewed Nov 9, 2022
View reviewed changes
Copy link

@ebakernz ebakernz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would this be better?

$query = self::$query ?? '';

@kjmnavarro kjmnavarro requested a review from ebakernz November 9, 2022 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ebakernz ebakernz ebakernz approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kjmnavarro @ebakernz