Skip to content

Temporarily remove statement-function #339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 28, 2025
Merged

Temporarily remove statement-function #339

merged 1 commit into from
Feb 28, 2025

Conversation

ZedThree
Copy link
Member

See #338

@ZedThree ZedThree force-pushed the disable-statement-functions branch from c2baa0d to 576493c Compare February 28, 2025 13:46
LiamPattinson
LiamPattinson approved these changes Feb 28, 2025
View reviewed changes
Copy link
Collaborator

@LiamPattinson LiamPattinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I'm suddenly glad we ported over all of the deprecated/removed rule stuff from Ruff, as it makes this sort of situation really easy to resolve.

@ZedThree ZedThree merged commit 30234d7 into main Feb 28, 2025
19 checks passed
@ZedThree ZedThree deleted the disable-statement-functions branch February 28, 2025 14:21
@ZedThree ZedThree added the rule A new rule for the linter label Feb 28, 2025
@chenrui333 chenrui333 mentioned this pull request Mar 4, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LiamPattinson LiamPattinson LiamPattinson approved these changes

Assignees
No one assigned
Labels
rule A new rule for the linter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ZedThree @LiamPattinson