Skip to content

Conversation

ZedThree
Copy link
Member

@ZedThree ZedThree commented Dec 6, 2024

Closes #23

There's a sort of naming clash with external-function -- I've called
this external-statement, but I think it's maybe better as
external-procedure. I wonder if that might be better as something
like procedure-not-in-module?

Copy link
Collaborator

@LiamPattinson LiamPattinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ZedThree ZedThree merged commit b9867f6 into main Dec 6, 2024
24 checks passed
@ZedThree ZedThree deleted the add-prefer-interface branch December 6, 2024 11:59
@LiamPattinson
Copy link
Collaborator

There's a sort of naming clash with external-function -- I've called
this external-statement, but I think it's maybe better as
external-procedure. I wonder if that might be better as something
like procedure-not-in-module?

I think procedure-not-in-module and external-procedure would be the best names, but it'll be hard to avoid some confusion since they're both arguing against the same practice but from different angles. We could set up some redirects for this, but I feel like having both external-function and external-procedure pointing at different rules might be too confusing, so I think a breaking change may be in order. Maybe raise an issue for this?

@ZedThree ZedThree added the rule A new rule for the linter label Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rule A new rule for the linter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prefer interface to external
2 participants