Fix explain bug with RuleSelector, improve explain output #110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I added a small function to the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While trying out 7a4b965 in #108, I found that the
explaincommand was no longer working properly. This PR fixes the bug, and while I was at it I also improved the output forexplain, updated the README, and improved the help text that's printed when things go wrong.explainnow prints the name of the rule alongside the code, but it's in camel-case. There are a few Rust libraries that allow you to convert to other cases, like sentence case, but these aren't clever enough to renameIOErrortoIO errororNonStandardFileExtensiontoNon-standard file extension, so for now I've left it at camel-case.