-
Notifications
You must be signed in to change notification settings - Fork 41
Fix np bug in LinearConstraintProjection
#2067
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Memory benchmark result| Test Name | %Δ | Master (MB) | PR (MB) | Δ (MB) | Time PR (s) | Time Master (s) |
| -------------------------------------- | ------------ | ------------------ | ------------------ | ------------ | ------------------ | ------------------ |
test_objective_jac_w7x | 5.84 % | 3.850e+03 | 4.075e+03 | 224.73 | 38.49 | 35.84 |
test_proximal_jac_w7x_with_eq_update | -1.02 % | 6.534e+03 | 6.468e+03 | -66.42 | 161.60 | 160.96 |
test_proximal_freeb_jac | 0.23 % | 1.321e+04 | 1.324e+04 | 30.85 | 83.43 | 82.03 |
test_proximal_freeb_jac_blocked | -0.39 % | 7.516e+03 | 7.487e+03 | -29.07 | 71.79 | 72.01 |
test_proximal_freeb_jac_batched | 0.23 % | 7.464e+03 | 7.481e+03 | 17.52 | 71.78 | 72.90 |
test_proximal_jac_ripple | -0.87 % | 3.478e+03 | 3.448e+03 | -30.42 | 64.99 | 64.38 |
test_proximal_jac_ripple_bounce1d | -1.98 % | 3.568e+03 | 3.498e+03 | -70.82 | 75.13 | 75.74 |
test_eq_solve | -1.32 % | 2.016e+03 | 1.990e+03 | -26.68 | 93.57 | 92.45 |For the memory plots, go to the summary of |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2067 +/- ##
==========================================
- Coverage 94.52% 94.52% -0.01%
==========================================
Files 102 102
Lines 28712 28713 +1
==========================================
Hits 27141 27141
- Misses 1571 1572 +1
🚀 New features to boost your workflow:
|
|
Add a test passing in |
dpanici
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test
|
Overlap with #2032 ? at least the bug fix there |
Oh yeah, the second bug is also fixed there. The first one is not. |
Resolves #2068
factorize_linear_constraintsfor numpy arrayx_scalex_scale. For example, if I want to give a scale to lambda (to make it have a similar magnitude as R and Z) based on the major radius etc. currently I cannot because the check x<100 will override that scale.