Skip to content

Conversation

@YigitElma
Copy link
Collaborator

@YigitElma YigitElma commented Jan 26, 2026

Resolves #2068

  • Fixes the bug in factorize_linear_constraints for numpy array x_scale
  • Removes any change applied to the user-supplied x_scale. For example, if I want to give a scale to lambda (to make it have a similar magnitude as R and Z) based on the major radius etc. currently I cannot because the check x<100 will override that scale.

@YigitElma YigitElma self-assigned this Jan 26, 2026
@YigitElma YigitElma requested review from a team, ddudt, dpanici, f0uriest, rahulgaur104 and unalmis and removed request for a team January 26, 2026 23:04
@github-actions
Copy link
Contributor

github-actions bot commented Jan 26, 2026

Memory benchmark result

|               Test Name                |      %Δ      |    Master (MB)     |      PR (MB)       |    Δ (MB)    |    Time PR (s)     |  Time Master (s)   |
| -------------------------------------- | ------------ | ------------------ | ------------------ | ------------ | ------------------ | ------------------ |
  test_objective_jac_w7x                 |    5.84 %    |     3.850e+03      |     4.075e+03      |    224.73    |       38.49        |       35.84        |
  test_proximal_jac_w7x_with_eq_update   |   -1.02 %    |     6.534e+03      |     6.468e+03      |    -66.42    |       161.60       |       160.96       |
  test_proximal_freeb_jac                |    0.23 %    |     1.321e+04      |     1.324e+04      |    30.85     |       83.43        |       82.03        |
  test_proximal_freeb_jac_blocked        |   -0.39 %    |     7.516e+03      |     7.487e+03      |    -29.07    |       71.79        |       72.01        |
  test_proximal_freeb_jac_batched        |    0.23 %    |     7.464e+03      |     7.481e+03      |    17.52     |       71.78        |       72.90        |
  test_proximal_jac_ripple               |   -0.87 %    |     3.478e+03      |     3.448e+03      |    -30.42    |       64.99        |       64.38        |
  test_proximal_jac_ripple_bounce1d      |   -1.98 %    |     3.568e+03      |     3.498e+03      |    -70.82    |       75.13        |       75.74        |
  test_eq_solve                          |   -1.32 %    |     2.016e+03      |     1.990e+03      |    -26.68    |       93.57        |       92.45        |

For the memory plots, go to the summary of Memory Benchmarks workflow and download the artifact.

@codecov
Copy link

codecov bot commented Jan 26, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.52%. Comparing base (7aa703f) to head (fd49608).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2067      +/-   ##
==========================================
- Coverage   94.52%   94.52%   -0.01%     
==========================================
  Files         102      102              
  Lines       28712    28713       +1     
==========================================
  Hits        27141    27141              
- Misses       1571     1572       +1     
Files with missing lines Coverage Δ
desc/objectives/utils.py 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dpanici
Copy link
Collaborator

dpanici commented Jan 27, 2026

Add a test passing in D somewhere to ensure it runs without error?

Copy link
Collaborator

@dpanici dpanici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test

@YigitElma YigitElma requested a review from dpanici January 28, 2026 05:40
@YigitElma YigitElma added the easy Short and simple to code or review label Jan 28, 2026
@dpanici
Copy link
Collaborator

dpanici commented Jan 29, 2026

Overlap with #2032 ? at least the bug fix there

@YigitElma
Copy link
Collaborator Author

Overlap with #2032 ? at least the bug fix there

Oh yeah, the second bug is also fixed there. The first one is not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

easy Short and simple to code or review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Problems in LinearConstraintProjection x_scale

3 participants