Allow DESC to read wout files that lack lrfp logical (like VMEC++ files)

[dpanici]

No description provided.

[YigitElma]

Does VMEC++ always output without poloidal flux label?

[dpanici]

yes for now at least https://github.com/proximafusion/vmecpp/blob/4f41149a01e8a43affcdb83bebb82c47b2a9a8a7/tests/test_init.py#L165

[jonathanschilling]

Ahh yeah, sorry for the inconsistency. I hope it is not too inconvenient for you guys to have to work around that. We probably should add these wout variables to VMEC++, even if they would just be static values, as in the case of lrfp__logical__. Or maybe we'll even see a PR adding these some time 🤞 ?

[YigitElma]

Thanks for the reply @jonathanschilling ! I think the current workaround is fine (as long as a user gives an output with poloidal flux label that doesn't have this attribute).

[github-actions]

Memory benchmark result

|               Test Name                |      %Δ      |    Master (MB)     |      PR (MB)       |    Δ (MB)    |    Time PR (s)     |  Time Master (s)   |
| -------------------------------------- | ------------ | ------------------ | ------------------ | ------------ | ------------------ | ------------------ |
  test_objective_jac_w7x                 |    5.18 %    |     3.815e+03      |     4.013e+03      |    197.61    |       37.95        |       34.04        |
  test_proximal_jac_w7x_with_eq_update   |   -2.34 %    |     6.715e+03      |     6.557e+03      |   -157.43    |       154.82       |       154.95       |
  test_proximal_freeb_jac                |   -0.19 %    |     1.319e+04      |     1.317e+04      |    -24.58    |       80.52        |       79.81        |
  test_proximal_freeb_jac_blocked        |   -0.23 %    |     7.630e+03      |     7.612e+03      |    -17.93    |       70.99        |       71.08        |
  test_proximal_freeb_jac_batched        |    0.03 %    |     7.597e+03      |     7.599e+03      |     1.92     |       71.59        |       71.79        |
  test_proximal_jac_ripple               |   -0.05 %    |     3.401e+03      |     3.400e+03      |    -1.74     |       58.35        |       58.45        |
  test_proximal_jac_ripple_bounce1d      |    2.11 %    |     3.494e+03      |     3.567e+03      |    73.64     |       74.23        |       74.73        |
  test_eq_solve                          |    3.81 %    |     1.978e+03      |     2.053e+03      |    75.38     |       91.18        |       91.46        |

For the memory plots, go to the summary of Memory Benchmarks workflow and download the artifact.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.76%. Comparing base (e277745) to head (b96d3e6).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2014      +/-   ##
==========================================
- Coverage   95.77%   95.76%   -0.01%     
==========================================
  Files         101      101              
  Lines       27756    27757       +1     
==========================================
- Hits        26583    26582       -1     
- Misses       1173     1175       +2     

Files with missing lines	Coverage Δ
desc/vmec.py	91.90% <100.00%> (+<0.01%)	⬆️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.