Non-uniform FFTs #1834
Merged
Non-uniform FFTs #1834
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unalmis
added
performance
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Collaborator
|
Bumping the benchmarks since they are pretty past in the conversation |
Collaborator
Author
|
I keep spending significant time debugging all the failing tests and fixing merges etc from other prs to maintain this Pr. Please do not continue to block PR for no reason as these delays also handicap my time/ability to submit the publication. |
unalmis
requested review from
a team,
YigitElma,
ddudt,
dpanici,
f0uriest and
rahulgaur104
and removed request for
a team,
YigitElma,
ddudt,
dpanici,
f0uriest and
rahulgaur104
Collaborator
Author
dpanici
approved these changes
Oct 8, 2025
Collaborator
dpanici
left a comment
dpanici
left a comment
There was a problem hiding this comment.
@YigitElma has made an issue with NERSC for the gpu jax-finnuft install there
we should also make an issue that tracks the gpu jax-finnuft pip wheels issue as well so we can update our installs once they resolve that
Collaborator
Author
|
alright thanks I'll merge then |
Collaborator
Author
|
There was a comment that was written here to which I replied through proper channel. If anyone feels similarly, you can message through the proper channel. Note that I had accepted the only remaining ultimatum for approval put forth by the second reviewer. |
DMCXE
pushed a commit
to DMCXE/DESC-OOPS
that referenced
this pull request
Oct 14, 2025
This PR fixes failing benchmarks as required from changes made in PlasmaControl#1946. PlasmaControl#1834 PR will rename the variable `spline` to `use_bounce1d`, and without this change, both memory and performance benchmarks fail.
DMCXE
pushed a commit
to DMCXE/DESC-OOPS
that referenced
this pull request
Oct 14, 2025
Significantly improve the performance speed and memory of bounce integrals by factor of >=10 for computation of problem sizes in the tests, and larger improvements for bigger problems and Jacobian. - [x] Resolves PlasmaControl#1154 - [x] Resolves PlasmaControl#1294 - [x] Resolves PlasmaControl#1574 - [x] Resolves PlasmaControl#1851 - [x] Resolves PlasmaControl#1864 (not the actual regression, just makes computation less painful). - [x] Resolves PlasmaControl#1938
DMCXE
pushed a commit
to DMCXE/DESC-OOPS
that referenced
this pull request
Oct 14, 2025
Significantly improve the performance speed and memory of bounce integrals by factor of >=10 for computation of problem sizes in the tests, and larger improvements for bigger problems and Jacobian. - [x] Resolves PlasmaControl#1154 - [x] Resolves PlasmaControl#1294 - [x] Resolves PlasmaControl#1574 - [x] Resolves PlasmaControl#1851 - [x] Resolves PlasmaControl#1864 (not the actual regression, just makes computation less painful). - [x] Resolves PlasmaControl#1938
DMCXE
pushed a commit
to DMCXE/DESC-OOPS
that referenced
this pull request
Oct 14, 2025
Significantly improve the performance speed and memory of bounce integrals by factor of >=10 for computation of problem sizes in the tests, and larger improvements for bigger problems and Jacobian. - [x] Resolves PlasmaControl#1154 - [x] Resolves PlasmaControl#1294 - [x] Resolves PlasmaControl#1574 - [x] Resolves PlasmaControl#1851 - [x] Resolves PlasmaControl#1864 (not the actual regression, just makes computation less painful). - [x] Resolves PlasmaControl#1938
DMCXE
pushed a commit
to DMCXE/DESC-OOPS
that referenced
this pull request
Oct 22, 2025
Significantly improve the performance speed and memory of bounce integrals by factor of >=10 for computation of problem sizes in the tests, and larger improvements for bigger problems and Jacobian. - [x] Resolves PlasmaControl#1154 - [x] Resolves PlasmaControl#1294 - [x] Resolves PlasmaControl#1574 - [x] Resolves PlasmaControl#1851 - [x] Resolves PlasmaControl#1864 (not the actual regression, just makes computation less painful). - [x] Resolves PlasmaControl#1938
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Significantly improve the performance speed and memory by factor of 20 for computation of problem sizes in the tests, and larger improvements for bigger problems and Jacobian.