Skip to content

Release: use api hook migration part 2 #2493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 63 commits into from
Apr 24, 2025
Merged

Release: use api hook migration part 2 #2493

merged 63 commits into from
Apr 24, 2025

Conversation

mohitb35
Copy link
Collaborator

@mohitb35 mohitb35 commented Apr 10, 2025 •
edited
Loading

mohitb35 and others added 30 commits March 25, 2025 21:46
@mohitb35
refactor: remove hardcoded font sizes from features/common
940395a
@mohitb35
refactor: corrects name of Home component in tenant pages
36ad64d
@mohitb35
refactor: replace standard hardcoded font-sizes with variables
401b0a1
@mohitb35
Merge branch 'develop' into feature/rationalize-fonts
49ad300
@mohitb35
refactor: replace standard hardcoded fontSizes with variables
63a5731
@mohitb35
fix: fix incorrect SCSS import syntax (InfoAndCta)
7b7cdf2
@mohitb35
refactor: replace rem font sizes with px equivalents in themeStyles
be44c9a 
- removes rem font size variables as they will not be used
@mohitb35
refactor: rename default export function to LeaderBoard in LeaderBoar…
5443679 
…d component
@mohitb35
refactor: replace hardcoded font sizes with variables in global styles
71ce1ec
@mohitb35
refactor: replace hardcoded font sizes with variables (across code base)
e3b3ad4 
- /src/features/common
-/src/features/donations
-/src/features/projectsV2
-/src/features/user
-/src/tenants/planet/LeaderBoard
- also removes some unused classes
@sunilsabatp
refactor(redeem-code): Improve tye definition and api handling in red…
7771970 
…eem code
@sunilsabatp
refactor(tree-mapper): use api hook for api calls
80de006
@sunilsabatp
refactor(my-species) : use api hook for api calls and improve type de…
c0dfb8c 
…finitions
@sunilsabatp
refactor: use api hook for unauthenticated get request
314371a
@sunilsabatp
refactor: improve variable names for better clarity
778dfbb
@sunilsabatp
refactor: remove unnecessary Record type in NewSpecies
a2e4f9c
@sunilsabatp
refactor: project types & improve maintainability.
3e0e035 
-Extracted common omitted properties into OmittedProjectProps to reduce repetition.
-Introduced a reusable BaseProject<T> type for better scalability.
-Refactored TreeProject and ConservationProject to extend BaseProject<T>.
-Improved type safety and readability in ProjectApiResponse.
@mohitb35
feat: removes font sizes less than 10px
6737524 
- adjusts font sizes to 10px where these were used
- makes minor adjustments to align interventions and site dropdown correctly in mobile view
@mohitb35
fix: adjusts styles for Redeem success message
88618d0
@mohitb35
fix: adjusts link color for DirectGift popup
e73902f
@mohitb35
fix: adjust background color for selected records (non mobile)
0ce97fb 
- affects payment history, recurring subscriptions, planetcash transactions
@mohitb35
fix: minor style adjustments for public profile page
8de149d
@mohitb35
Merge branch 'develop' into feature/use-api-hook5
1696bfd
@mohitb35
refactor: replace getRequest with useApi hook for API calls across mu…
9bdbaf7 
…ltiple components
@mohitb35
refactor: replace getRequest with useApi hook in CurrencyContext for …
778f821 
…API calls
@sunilsabatp
feat(api): add support for queryParams in putApiAuthenticated
1a2485b
@sunilsabatp
refactor(embed-modal): use API hook and define type for API payload
ee256cf
@sunilsabatp
refactor(targets-modal): use API hook and define type for API payload
3f07839
@sunilsabatp
refactor(support-pin): use API hook and define type for API payload
8233ac6
@sunilsabatp
refactor(UploadImage): use api hook for auth delete request
424a896
mohitb35 added 2 commits April 24, 2025 12:24
@mohitb35
refactor(UserPropsProvider): remove unused getsessionId deps from fet…
12f615e 
…chUserProfile
@mohitb35
Merge pull request #2494 from Plant-for-the-Planet-org/feature/use-ap…
5fc659d 
…i-hook11

refactor(usePropContext):  handle user profile fetch with impersonati…
@mohitb35 mohitb35 requested a review from sunilsabatp April 24, 2025 07:52
sunilsabatp
sunilsabatp approved these changes Apr 24, 2025
View reviewed changes
Copy link
Contributor

@sunilsabatp sunilsabatp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mohitb35
Merge pull request #2472 from Plant-for-the-Planet-org/hotfix/correct…
13c72f4 
…s-wrong-component-naming

Corrects incorrect component/file names in webapp
@mohitb35 mohitb35 requested a review from mariahosfeld April 24, 2025 09:32
mariahosfeld
mariahosfeld requested changes Apr 24, 2025
View reviewed changes
Copy link
Contributor

@mariahosfeld mariahosfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue while testing:

  • switching currency only takes effect after manual refresh (seen on main screen, tested via chrome and safari on mobile)

@mariahosfeld mariahosfeld mentioned this pull request Apr 24, 2025
Closed
1 task
@mariahosfeld mariahosfeld self-requested a review April 24, 2025 10:32
mariahosfeld
mariahosfeld approved these changes Apr 24, 2025
View reviewed changes
Copy link
Contributor

@mariahosfeld mariahosfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@mariahosfeld
Copy link
Contributor

Issue while testing:

  • switching currency only takes effect after manual refresh (seen on main screen, tested via chrome and safari on mobile)

Will be handled in different release.

@mariahosfeld mariahosfeld merged commit 574e9d1 into main Apr 24, 2025
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mariahosfeld mariahosfeld mariahosfeld approved these changes

@sunilsabatp sunilsabatp sunilsabatp approved these changes

Assignees

No one assigned

Labels

PR: merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mohitb35 @mariahosfeld @sunilsabatp @sagararyal