Fix broken URL path in generateUrl() #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed broken/missing issuer and user values that weren't getting added to the returned URL from the generateUrl() function, since "otpauth://totp" is not read as a valid URL.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is to fix broken/missing issuer and user values that weren't getting added to the returned URL from the
generateUrl()function.After some digging, it appears that
otpauth://totpis not read as a valid URL, as seen below.//totpis getting read as the pathname, instead of being included in the protocol, in which case seems to cause the URL() constructor to ignore attempts to set a new pathname on the URL.To circumvent this, the pathname value, which includes the issuer and user values has been moved into the URL constructor, which now allows
generateUrl()to return the proper, fullotpauth://URL value.Before:
otpauth://totp/?issuer=Issuer&period=30&secret=valueAfter:
otpauth://totp/Issuer:fake@email.com?issuer=Issuer&period=30&secret=value