api: serve all text/* as text/plain #850
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i hereby approve @brmzkw commit! |
brmzkw
approved these changes
Apr 18, 2025
niluje@ spotted that text/xml was still interpreted; so let's use the big hammer and serve all text/* stuff as text/plain to stay on the safe side. The intent is to always show the content of the files in the UI, so we have to prevent the browser from trying to be 'smart'.
seems like we really care about being able to render HTML in the iframe, so add a raw parameter to force text/plain but otherwise leave it as-is. This allows browsing a backup of a website from the UI.
There are three ways to visualize a file: * default: detect the content type * raw: serve the file as text/plain * highlight: we enable syntax coloration
Instead of having two distinct parameters for ?raw and ?highlight, we now have only one parameter ?render that is either: * text: force Content-Type to text/plain * auto: detect the Content-Type based on the file content * code: enable code syntax highlighting
brmzkw
approved these changes
Apr 21, 2025
poolpOrg
approved these changes
Apr 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
niluje@ spotted that text/xml was still interpreted; so let's use the big hammer and serve all text/* stuff as text/plain to stay on the safe side.
The intent is to always show the content of the files in the UI, so we have to prevent the browser from trying to be 'smart'.