api: don't compute the error's total #848
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poolpOrg
reviewed
Apr 18, 2025
We can just reuse the what we know from the directory.Summary to know how many errors there are below a certain path; should speed up considerably the response time in the UI when browsing snapshots with a huge number of errors on slow links / storages.
omar-polo
force-pushed
the
op/dont-compute-errors-total
branch
from
7da1649 to
bbb386a
Compare
mathieu-plak
approved these changes
Apr 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can just reuse the what we know from the directory.Summary to know how many errors there are below a certain path; should speed up considerably the response time in the UI when browsing snapshots with a huge number of errors on slow links / storages.