Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Add new entries inside arrays #14

Closed
ryselgh opened this issue Jan 10, 2021 · 8 comments
Closed

[Feature request] Add new entries inside arrays #14

ryselgh opened this issue Jan 10, 2021 · 8 comments
Assignees
Labels
enhancement New feature or request

Comments

@ryselgh
Copy link

ryselgh commented Jan 10, 2021

I noticed that you can add entries in structs but only remove them inside arrays.
Is it possible to extend arrays with new entries?
Thank you for your awesome work btw!

@PixelRick PixelRick self-assigned this Jan 10, 2021
@PixelRick PixelRick added the enhancement New feature or request label Jan 10, 2021
@PixelRick
Copy link
Owner

PixelRick commented Jan 10, 2021

That's possible for dynamic arrays. There was an "insert new here" in the context menu at some point in time. I will reintroduce it.
However it will depend on the array element type. Inserting a new handle for instance is unusable without a database of class hierarchy, (a handle is a shared pointer to a base class or interface).

@ryselgh
Copy link
Author

ryselgh commented Jan 10, 2021

Yes I thought about fixed arrays that would break the savegame, but there are some arrays that are clearly dynamic comparing multiple savegames. Maybe you can add a disclaimer about adding entries that would break the save if not knowing what you're doing

PixelRick added a commit that referenced this issue Jan 10, 2021
@PixelRick
Copy link
Owner

Available in the release v0.5.3-alpha. Please confirm that it is to your liking.

@ryselgh
Copy link
Author

ryselgh commented Jan 16, 2021

Actually what I mean is those elements in the appearence customization section:

image

I can assure you that the size is different between different savegames and would be extremely useful to add new elements inside those array.

@PixelRick
Copy link
Owner

PixelRick commented Jan 16, 2021

I disabled adding/removing explicitly from this array until I knew better. I am going to enable it but the fact that the cnames are unknown may be a problem for users. (I see that the "remove" should have been disabled but wasn't)

@ryselgh
Copy link
Author

ryselgh commented Jan 16, 2021

It's not necessary to know exactly cnames hashes, as users can reference them by comparing two savegames and add (or remove) appearence features to their character just by copying them from other saves as they are.
I can confirm that they are kind of unique IDs for those features. I managed to almost fully change my character gender by copying each cname and property values.

@PixelRick
Copy link
Owner

Forced push to fix a typo.

@ryselgh
Copy link
Author

ryselgh commented Jan 16, 2021

Tested and works perfectly, thanks!

@ryselgh ryselgh closed this as completed Jan 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants