Move gui windows to comptime modding #2198
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codemob-dev
changed the title
Collaborator
|
Before I start getting deeper into this PR, two things:
As a side quest, I am seriously considering if we could make the components moddable too. Current list of components is far from being exhaustive. It would be good for consistency, even if it is not strictly necessary. |
Contributor
Author
Me too |
Contributor
Author
That sounds... interesting to implement |
Contributor
Author
|
Closing this because of @Argmaster's rewrite of the ui. |
github-project-automation
bot
moved this from Low Priority
to Easy to Review
in PRs to review
Collaborator
For research purposes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1537. I had to modify the build script a bit to allow for subdirectories in mods.