Change log rotation to be more similar to branches, and also remove log_top

[OneAvargeCoder193]

Fixes #357

Stuff left to do

• Make them more like branches
• Make them rotate Fixed automatically by making them like branches
• Let them be chiseled like stairs? This will be a future pr
• Automatic migration between old and new logs

[OneAvargeCoder193]

Not sure how to translate old worlds into new ones with this, unless there is some way to migrate rotation mode data

[Argmaster]

Please don't remove log top, we don't have item migrations to correctly handle that.

[careeoki]

Some thoughts:

The texture gets oriented wrong in some directions:
left is correct, right is incorrect

In a situation like this, I think it should just be the line texture instead of a ton of intersections/crosses. That way it would look like a big tree trunk. (new textures wouldn't make this any better)

I would like to have log inside textures (imagine minecraft's stripped logs) to avoid situations like this:
And we'd also need a texture for the log top without the outline of bark

[OneAvargeCoder193]

In a situation like this, I think it should just be the line texture instead of a ton of intersections/crosses. That way it would look like a big tree trunk. (new textures wouldn't make this any better)

I'm not sure how I could implement it though. And anything i do would create numerous edge cases

[OneAvargeCoder193]

Now we just need the new textures for all the logs and i can mark this pr as ready for review

[careeoki]

@OneAvargeCoder193 It's doing a thing

[careeoki]

*In some directions

[Argmaster]

If you are lucky enough for #1503 to be merged before this you should be able to migrate old log items to new log types. This will also migration battle test, even with block merging since both top and log should be merged into one log item. Surely we will see all the bugs!

Anyway, I didn't participate in production of this code so I will review It tomorrow to catch any obvious errors.

[careeoki]

@OneAvargeCoder193 made a PR on your fork

[OneAvargeCoder193]

I fixed everything

[IntegratedQuantum]

Please don't forget to also change the biomes and the corresponding tree generator, such that they generate the new logs correctly in the forest.
This will make removing the old logs easier once item migrations are ready.

I will merge once you have acknowledged this.

[OneAvargeCoder193]

Please don't forget to also change the biomes and the corresponding tree generator, such that they generate the new logs correctly in the forest. This will make removing the old logs easier once item migrations are ready.
So do i just change simpletreegenerator and all of the instances of it in assets?

[IntegratedQuantum]

yes

[IntegratedQuantum]

Also check if there are any other biomes that reference logs some how, there might be some other structures that use logs too.