-
Notifications
You must be signed in to change notification settings - Fork 187
Add coniferous trees the way I like them #1377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add coniferous trees the way I like them #1377
Conversation
af6ff15 to
666e58d
Compare
|
Yee, I will do my best to fix everything that comes up in reviews asap, but without reviews we won't merge this C: |
|
|
|
@ikabod-kee I summon you! Speak now or forever hold your peace! |
|
Well, since ikabod didn't share their opinion I assume they are happy with the result, so only technical reviews are required for this PR |
|
Let's not rush things. This certainly does need an artistic review first. |
|
So, @ikabod-kee could you please review this? I would like to merge this before the play session tomorrow. |
|
Sure thing |
ikabod-kee
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, reviewed. I actually quite like the roots without tree attachments in practice. The file structure isn't quite my cup of tea though, but hey, it's your tree, and it works!
IntegratedQuantum
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Honestly the file structure is a mess, and the files themselves are kind of unreviewable.
We really need some better to visualize these as well as their relations before we end up with a directory tree of thousands of random files that no one can search through.
Maybe #1387, maybe some kind of 3d tree diagram, maybe both
|
Since all of ikabods concerns have been addressed, I'll assume that this is ready for merge. |





I still need more variants of lushy branches, also the average branch variants seem a bit bare, too bare IMO, tho maybe these are things we could tweak later?