Skip to content

Crash when joining a world that has torches #2485

@Wunka

Description

@Wunka

Steps to Reproduce and Observed Behavior

On commit df0a059 I get this error while a World is loading:

thread 17117 panic: integer overflow
/home/Wunka/Documents/Cubyz/master/src/renderer/chunk_meshing.zig:538:36: 0x17f844b in getLight (Cubyz)
      val += cornerVals[dx][dy][dz]*@as(LightVector, @splat(integerWeight));
                                   ^
/home/Wunka/Documents/Cubyz/master/src/renderer/chunk_meshing.zig:386:26: 0x18ef051 in finish (Cubyz)
   const light = getLight(parent, .{face.position.x, face.position.y, face.position.z}, face.blockAndQuad.texture, face.blockAndQuad.quadIndex);
                         ^
/home/Wunka/Documents/Cubyz/master/src/renderer/chunk_meshing.zig:1282:25: 0x188677e in finishData (Cubyz)
  self.opaqueMesh.finish(self, &lightList, &lightMap);
                        ^
/home/Wunka/Documents/Cubyz/master/src/renderer/chunk_meshing.zig:1479:18: 0x17fc764 in finishNeighbors (Cubyz)
  self.finishData();
                 ^
/home/Wunka/Documents/Cubyz/master/src/renderer/chunk_meshing.zig:1153:23: 0x175d3a1 in generateMesh (Cubyz)
  self.finishNeighbors(lightRefreshList);
                      ^
/home/Wunka/Documents/Cubyz/master/src/renderer/chunk_meshing.zig:829:32: 0x1833d8d in generateLightingData (Cubyz)
      neighborMesh.generateMesh(&lightRefreshList);
                               ^
/home/Wunka/Documents/Cubyz/master/src/renderer/mesh_storage.zig:891:28: 0x1832fb7 in run (Cubyz)
  mesh.generateLightingData() catch mesh.deferredDeinit();
                           ^
/home/Wunka/Documents/Cubyz/master/src/utils.zig:920:20: 0x16ce373 in run (Cubyz)
    task.vtable.run(task.self);
                   ^
/home/Wunka/Documents/Cubyz/master/compiler/zig/lib/std/Thread.zig:558:13: 0x1609361 in callFn__anon_63101 (Cubyz)
            @call(.auto, f, args);
            ^
/home/Wunka/Documents/Cubyz/master/compiler/zig/lib/std/Thread.zig:830:30: 0x15625dd in entryFn (Cubyz)
                return callFn(f, args_ptr.*);
                             ^
???:?:?: 0x7f0c7cc9698a in ??? (/usr/lib/libc.so.6)
???:?:?: 0x7f0c7cd1a9cb in ??? (/usr/lib/libc.so.6)
Experienced time travel. Current time: -4732 Last time: -4731
./debug_linux.sh: line 31: 17113 Aborted                    (core dumped) ./zig-out/bin/Cuby

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugsomething isn't working in the intended way

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions