Skip to content

Introduced protections against system command injection #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pixeebot wants to merge 1 commit into from
Closed

Introduced protections against system command injection #25

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion flow-server/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,10 @@
<version>${hibernate.validator.version}</version>
<scope>test</scope>
</dependency>

<dependency>
Copy link
Author

@pixeebot pixeebot bot Mar 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This library holds security tools for protecting Java API calls.

License: MIT ✅ | Open source ✅ | More facts

<groupId>io.github.pixee</groupId>
<artifactId>java-security-toolkit</artifactId>
</dependency>
</dependencies>
<build>
<resources>
Expand Down
3 changes: 2 additions & 1 deletion ...rver/src/main/java/com/vaadin/flow/server/frontend/installer/DefaultArchiveExtractor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
*/
package com.vaadin.flow.server.frontend.installer;

import io.github.pixee.security.SystemCommand;
import java.io.File;
import java.io.FileInputStream;
import java.io.FileOutputStream;
Expand Down Expand Up @@ -63,7 +64,7 @@ private void extractMSIArchive(File archiveFile, File destinationDirectory)
throws IOException, ArchiveExtractionException {
String command = "msiexec /a " + archiveFile.getAbsolutePath()
+ " /qn TARGETDIR=\"" + destinationDirectory + "\"";
Process child = Runtime.getRuntime().exec(command);
Process child = SystemCommand.runCommand(Runtime.getRuntime(), command);
try {
int result = child.waitFor();
if (result != 0) {
Expand Down
6 changes: 6 additions & 0 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,7 @@
<failsafe.parallel>all</failsafe.parallel>
<failsafe.threadCount>2</failsafe.threadCount>
<failsafe.perCoreThreadCount>true</failsafe.perCoreThreadCount>
<versions.java-security-toolkit>1.2.1</versions.java-security-toolkit>
</properties>

<repositories>
Expand Down Expand Up @@ -280,6 +281,11 @@
<artifactId>hamcrest-all</artifactId>
<version>1.3</version>
</dependency>
<dependency>
Copy link
Author

@pixeebot pixeebot bot Mar 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This library holds security tools for protecting Java API calls.

License: MIT ✅ | Open source ✅ | More facts

<groupId>io.github.pixee</groupId>
<artifactId>java-security-toolkit</artifactId>
<version>${versions.java-security-toolkit}</version>
</dependency>
</dependencies>
</dependencyManagement>

Expand Down
Loading