Skip to content

Fix import paths and CodegenApp initialization in examples #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

Fix import paths and CodegenApp initialization in examples #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions codegen-examples/examples/linear_webhooks/webhooks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
import modal.running_app
from codegen.extensions.events.app import CodegenApp
from codegen.extensions.events.codegen_app import CodegenApp
import modal

image = modal.Image.debian_slim(python_version="3.13").apt_install("git").pip_install("fastapi[standard]", "codegen>=v0.22.2")
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The use of a specific Python version (python_version="3.13") and package versions in pip_install could lead to maintenance challenges or performance issues if these versions are deprecated or have known vulnerabilities. It is recommended to allow for more flexibility in versioning or to ensure regular updates and checks for the dependencies to mitigate potential security risks and maintain compatibility.

app = CodegenApp(name="test-linear", modal_api_key="", image=image)
app = CodegenApp(name="test-linear")

# Here is an example implementation of setting up an endpoint for receiving webhook events from Linear.
# The @app.linear.event() decorator takes care of subscribing to the webhook and also unsubscribing when the deployment spun
Expand Down
4 changes: 2 additions & 2 deletions codegen-examples/examples/pr_review_bot/app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import logging
from logging import getLogger
import modal
from codegen.extensions.events.app import CodegenApp
from codegen.extensions.events.codegen_app import CodegenApp
from fastapi import Request
from codegen.extensions.github.types.events.pull_request import PullRequestLabeledEvent, PullRequestUnlabeledEvent
from helpers import remove_bot_comments, pr_review_agent
Comment on lines 1 to 7
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Redundant Imports

The module logging is imported twice: once with import logging and again with from logging import getLogger. This redundancy can be eliminated to improve code clarity and maintainability.

Recommendation:
Remove the line from logging import getLogger and use logging.getLogger instead.

Expand All @@ -26,7 +26,7 @@
)
)

app = CodegenApp(name="github", image=base_image, modal_api_key="")
app = CodegenApp(name="github")


@app.github.event("pull_request:labeled")
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Event Handler Robustness

The event handler handle_labeled does not include any error handling. If any part of the processing fails (e.g., network issues when posting to Slack, or issues with the pr_review_agent function), it could cause the application to crash or behave unpredictably.

Recommendation:
Implement try-except blocks around critical operations such as Slack notifications and calls to pr_review_agent. Log the errors appropriately and consider a retry mechanism or fail gracefully if necessary.

Expand Down
4 changes: 2 additions & 2 deletions codegen-examples/examples/ticket-to-pr/app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
from codegen import Codebase, CodeAgent
from codegen.extensions.clients.linear import LinearClient
from codegen.extensions.events.app import CodegenApp
from codegen.extensions.events.codegen_app import CodegenApp
from codegen.extensions.tools.github.create_pr import create_pr
from codegen.shared.enums.programming_language import ProgrammingLanguage
from helpers import create_codebase, format_linear_message, has_codegen_label, process_update_event
Expand All @@ -17,7 +17,7 @@

image = modal.Image.debian_slim(python_version="3.13").apt_install("git").pip_install("fastapi[standard]", "codegen==v0.26.3")
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Potential Security and Compatibility Issue with Docker Image Setup

The Docker image is being configured with a specific Python version (3.13) and additional installations via apt_install and pip_install. It's crucial to ensure that:

  1. The Python version 3.13 is compatible with all the libraries being installed and is a stable release.
  2. All libraries and tools installed (like git, fastapi, and codegen) are using versions that do not have known security vulnerabilities.

Recommendation:

  • Verify the compatibility of the Python version with all installed packages.
  • Regularly update the versions of the packages to their latest stable releases to mitigate any security vulnerabilities.


app = CodegenApp("linear-bot", image=image, modal_api_key="")
app = CodegenApp("linear-bot")


@app.cls(secrets=[modal.Secret.from_dotenv()], keep_warm=1)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security Concern with Handling Secrets

The @app decorator is used to configure the LinearApp class with secrets loaded from a dotenv file. This approach can be secure, but it depends heavily on the security of the dotenv file and the environment where the application is running.

Recommendation:

  • Ensure that the dotenv file is stored securely and is not accessible to unauthorized users.
  • Consider using more secure storage solutions for sensitive information, such as encrypted secret management services.

Expand Down