Enhance retry policy api #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PierreMardon
commented
Jun 16, 2024
Comment on lines
15
to
+19
| func giveUpAfter(timeout: TimeInterval) -> RetryPolicy { | ||
| GiveUpOnPolicyWrapper(wrapped: self, giveUpCriterium: { | ||
| let nextAttemptStart = Date().addingTimeInterval(retryDelay(for: $0)) | ||
| return nextAttemptStart >= $0.trialStart.addingTimeInterval(timeout) | ||
| }) | ||
| GiveUpCriteriaPolicyWrapper(wrapped: self) { attempt, wrappedDelay in | ||
| let nextAttemptStart = Date().addingTimeInterval(wrappedDelay) | ||
| return nextAttemptStart >= attempt.trialStart.addingTimeInterval(timeout) | ||
| } |
Contributor
Author
There was a problem hiding this comment.
This was the only reason retryDelay() was introduced.
As RetryPolicy is now considered stateless, there's no need to work around calling shouldRetry() in GiveUpCriteriaPolicyWrapper.
PierreMardon
force-pushed
the
feature/27-enhance-retry-policy-api
branch
from
0aff0d5 to
163bc9b
Compare
PierreMardon
force-pushed
the
feature/27-enhance-retry-policy-api
branch
from
163bc9b to
a3c1e5c
Compare
PierreMardon
added a commit
that referenced
this pull request
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #27
Criterium=>Criteriaaccording to common usageRetryPolicy. retryDelay()