Add minimum python version in setup.py #93
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks like latest released version don't support Python 3.5 anymore. It is failing on line https://github.com/Pithikos/python-websocket-server/blob/master/websocket_server/websocket_server.py#L296 because it is using a f-string which is only available in Python 3.6+. If it was intentional, this PR is adding the correct package metadata so pip can choose the right version depending on the user Python Version.
|
Good catch. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like latest released version don't support Python 3.5 anymore. It is
failing on line
https://github.com/Pithikos/python-websocket-server/blob/master/websocket_server/websocket_server.py#L296
because it is using a f-string which is only available in Python 3.6+.
If it was intentional, this PR is adding the correct package metadata so pip
can choose the right version depending on the user Python Version.