Skip to content

Add ssl support #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 14, 2021
Merged

Add ssl support #78

merged 5 commits into from
Jul 14, 2021

Conversation

eado
Copy link
Contributor

@eado eado commented Jul 24, 2019

Issue #35 should be resolved.

@eado
Copy link
Contributor Author

eado commented Jul 24, 2019

Documentation for the new features should be available in the updated README.md.

@eado eado marked this pull request as ready for review July 24, 2019 18:40
@kmtvar
Copy link

kmtvar commented Nov 14, 2019

Thank you for your ssl support. It worked very well. And here is a simple example code for a websocket client.

from websocket import create_connection
import ssl
ws = create_connection("wss://127.0.0.1:13254/", sslopt={"cert_reqs": ssl.CERT_NONE})
receive_message = ws.recv()
print(receive_message)

@@ -112,16 +113,22 @@ class WebsocketServer(ThreadingMixIn, TCPServer, API):
}
"""

key = None
cert = None
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these are probably redundant? Since already set in the __init__?

@Pithikos Pithikos merged commit 2c44f4c into Pithikos:master Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants