-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Social media stats graph on party detail page is missing #63
Comments
Any idea why this isn't showing up? |
I have some inkling, but I currently can't check, because party pages don't work on my local deployment. My plan is to meet with Putr tommorow so he can help me set it up properly, so I can work on this :) |
[#63] fix for social media graphs on party pages
The main issue was the fact that the intent was that it shows data from the last 6 months and because there was no data, it showed nothing. But there was a bug, because .getMonth() gives a reuslt from 0-11 and I thought it was 1-12, so it never gave up to date results. |
This seems to be working now. |
Graph looks nice but doesn't collect at intervals. Only one first value and the current creating a linear graph. |
This is (hopefully) just due to a lack of data. Give it some time and see if it fills out. |
Perhaps I could add that it does not show the data unless there is at least 5 pieces of data available? |
Maybe, I don't know. I think incomplete data is still better than nothing in this case. |
@collentine We've had problems with the scraper - there's too much data so @j-h-s has been working on refactoring it. |
This is starting to fill out slowly, but it's still only showing 2 or 3 data points and only from the past 3 months. Is this working as intended? There's definitely more data than that in the db. Also, could we maybe add an option to change the scope of the graph (e.g. to display 3 months, 6 months or 1 year of data where available)? |
I believe it is working as intended. The graph is suppsoed to show data for the last 6 months, but only one datapoint per 7 days. |
👍 |
… so that when there is less than 150 datapoints, it dooesn't show only every 7th datapoint
This should be working now. It was only an issue for a while last year due to a bug in the scraper, but that's been fixed now, so it shouldn't be a problem in the future. |
@GuruVII created a nice graph that's not showing up.
The text was updated successfully, but these errors were encountered: