Fix TeamBets module: bets blocked, broken odds, payout ignoring odds#1
Merged
Fix TeamBets module: bets blocked, broken odds, payout ignoring odds#1
Conversation
…ero, payout, and debug message Agent-Logs-Url: https://github.com/Pintuzoft/OSBase/sessions/a980a35d-ddc2-47cd-b79f-8f1833bff3cf Co-authored-by: Pintuzoft <6753348+Pintuzoft@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
Pintuzoft
March 27, 2026 12:45
View session
Owner
|
@copilot made a fix to teambets |
Copilot stopped work on behalf of
Pintuzoft due to an error
March 27, 2026 12:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The betting module was completely non-functional due to a bitwise operator bug blocking all bet placement, compounded by broken odds math and a payout that ignored odds entirely.
Bugs fixed
isOnATeam()alwaysfalse— used bitwise|instead of logical||, so every bet attempt was silently rejected with "You must be on a team":Odds calculation — integer division truncated all results to
0or1, and a zero-player team caused aDivideByZeroException:Payout ignored odds —
oddswas stored onBetbut never applied; winners only received their original stake back:Debug message — removed leftover
PrintToChat("[TeamBets]: WooHoo! you are here!!")fromhandleBetCommand.