[sc-25841] Remove 4MB limit for gRPC message payloads #49
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently our logic chunks data to send over gRPC according to numbers of rows of data, this led to large streamsets in the multivalue api erroring out while trying to recv this data on the client side.
This PR sets the limit for the client to receive from the server to be unlimited for the time being. This will allow arbitrarily-sized streamsets to have successful multivalue queries.
In the future we should update our logic to better handle these size limits when sending from the server, but this is a patch fix for now.
I tested this for 5000 streams on ni4ai, with a
sampling_frequency
of30
for 100seconds of data, this would error out on the master branch, but successfully returns the data on with this PR.MWE