Skip to content

refactor/download pingcap oci artifact 2#4138

Draft
wuhuizuo wants to merge 15 commits intomainfrom
refactor/download-pingcap-oci-artifact-2
Draft

refactor/download pingcap oci artifact 2#4138
wuhuizuo wants to merge 15 commits intomainfrom
refactor/download-pingcap-oci-artifact-2

Conversation

@wuhuizuo
Copy link
Contributor

@wuhuizuo wuhuizuo commented Feb 1, 2026

  • refactor(pipelines): add utils container to pipeline pod templates
  • refactor: add utils container to 9.0-beta pod yamls and switch to OCI artifact tool in pipelines
  • refactor(oci): extend utils container to remaining 9.0-beta pod manifests (lightning, br, e2e, jdbc, mysql, nodejs, python_orm, sqllogic, unit, check2)

@ti-chi-bot
Copy link

ti-chi-bot bot commented Feb 1, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot
Copy link

ti-chi-bot bot commented Feb 1, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign wuhuizuo for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the size/XXL label Feb 1, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @wuhuizuo, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request streamlines and modernizes the CI/CD pipeline infrastructure by standardizing artifact management. It introduces a common utility container for various test environments and transitions the artifact download process to leverage OCI (Open Container Initiative) artifacts. This refactoring aims to improve the consistency, reliability, and potentially the performance of pipeline executions by centralizing utility functions and adopting a more robust artifact distribution method.

Highlights

  • Introduction of a utils container: A new utils container, sourced from ghcr.io/pingcap-qe/cd/utils/release:v2025.10.12-7-gfdd779c, has been added to numerous Kubernetes pod templates across various release branches (6.2, 6.5, 8.2, 8.3, 8.4, and 9.0-beta) and test types. This container is configured with specific CPU and memory resources.
  • Migration to OCI Artifact Download: Jenkins Groovy pipeline scripts for jdbc, mysql, nodejs, and python_orm integration tests in the release-9.0-beta branch have been updated. This involves defining OCI artifact tags (OCI_TAG_PD, OCI_TAG_TIKV), switching the artifact host from FILE_SERVER_URL to OCI_ARTIFACT_HOST (hub-zot.pingcap.net/mirrors/hub), and utilizing a new script (download_pingcap_oci_artifact.sh) within the newly introduced utils container for downloading TiDB components.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the CI pipelines to download Pingcap OCI artifacts using a new utils container and a dedicated script. This is a good improvement that centralizes the artifact download logic. However, I've found a critical issue in several of the pod template YAML files where the new utils container is defined twice. This will cause the Kubernetes pods to fail to be created and will break the corresponding pipelines. Please see the detailed comments for the specific files that need to be fixed.

@wuhuizuo wuhuizuo force-pushed the refactor/download-pingcap-oci-artifact-2 branch 3 times, most recently from fa42992 to 24d63da Compare February 3, 2026 13:29
Switch pipeline to agent none and run checkout in a pod.
Compute OCI tags for pd/tikv/tiflash/ticdc, download artifacts from the
OCI mirror, prepare binaries (tiflash symlink, verify binaries) and
cache
workspace for downstream stages.
@wuhuizuo wuhuizuo force-pushed the refactor/download-pingcap-oci-artifact-2 branch from 24d63da to cb4235d Compare February 3, 2026 14:53
Compute OCI tags for pd/tikv/tiflash from the PR and download
component binaries into bin/ via the OCI downloader script.
Switch pipeline to agent none and run checkout/prepare in a
dedicated pod, add a workspace cache for matrix pods, and use
REFS.repo for directory handling. Adjust timeouts accordingly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

1 participant