Conversation
wuhuizuo
commented
Feb 1, 2026
- refactor(pipelines): add utils container to pipeline pod templates
- refactor: add utils container to 9.0-beta pod yamls and switch to OCI artifact tool in pipelines
- refactor(oci): extend utils container to remaining 9.0-beta pod manifests (lightning, br, e2e, jdbc, mysql, nodejs, python_orm, sqllogic, unit, check2)
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Summary of ChangesHello @wuhuizuo, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request streamlines and modernizes the CI/CD pipeline infrastructure by standardizing artifact management. It introduces a common utility container for various test environments and transitions the artifact download process to leverage OCI (Open Container Initiative) artifacts. This refactoring aims to improve the consistency, reliability, and potentially the performance of pipeline executions by centralizing utility functions and adopting a more robust artifact distribution method. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request refactors the CI pipelines to download Pingcap OCI artifacts using a new utils container and a dedicated script. This is a good improvement that centralizes the artifact download logic. However, I've found a critical issue in several of the pod template YAML files where the new utils container is defined twice. This will cause the Kubernetes pods to fail to be created and will break the corresponding pipelines. Please see the detailed comments for the specific files that need to be fixed.
… artifact tool in pipelines
…ests (lightning, br, e2e, jdbc, mysql, nodejs, python_orm, sqllogic, unit, check2)
…I artifact downloader
fa42992 to
24d63da
Compare
Switch pipeline to agent none and run checkout in a pod. Compute OCI tags for pd/tikv/tiflash/ticdc, download artifacts from the OCI mirror, prepare binaries (tiflash symlink, verify binaries) and cache workspace for downstream stages.
24d63da to
cb4235d
Compare
Compute OCI tags for pd/tikv/tiflash from the PR and download component binaries into bin/ via the OCI downloader script. Switch pipeline to agent none and run checkout/prepare in a dedicated pod, add a workspace cache for matrix pods, and use REFS.repo for directory handling. Adjust timeouts accordingly.