feat: support ci on new branch release9.0-beta.2#3609
feat: support ci on new branch release9.0-beta.2#3609ti-chi-bot[bot] merged 7 commits intoPingCAP-QE:mainfrom
Conversation
…ern in postsubmit jobs - Updated the postsubmit job configuration to include a new regex pattern for release branches, allowing for more flexible versioning in the CI/CD pipeline.
- Introduced new pipeline jobs for Kafka and Pulsar integration tests (light and heavy). - Added storage integration test jobs (light and heavy) to enhance testing coverage. - Updated the presubmit configuration to include these new jobs, ensuring they are triggered correctly. - Each job includes specific resource configurations and environment setups for effective testing.
…ration pipelines - Updated both heavy and light MySQL integration pipeline configurations to enable the `parallelsAlwaysFailFast()` option, improving error handling during parallel execution.
…ciated configurations in new release-9.0-beta.2 - Deleted the pull_tiflash_test Groovy script and its corresponding YAML pod configuration. - Updated the presubmit configuration to remove references to the pull_tiflash_test job, streamlining the CI/CD pipeline.
…dynamic reference
- Modified the compatibility and integration test scripts to replace hardcoded version 'release-9.0-beta.1' with a dynamic reference '${REFS.base_ref}', ensuring the correct binaries are downloaded based on the current branch context.
…release-9.0-beta - Introduced a new pipeline job for the TiFlash test, specifically for the release-9.0-beta branch. - The job is disabled by default, reflecting its removal in the master branch. - Configured parameters and SCM settings for the job, ensuring it aligns with the CI/CD pipeline structure.
|
I Skip it since the diff size(81287 bytes > 80000 bytes) is too large |
There was a problem hiding this comment.
Summary of Changes
Hello @purelind, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request significantly expands and refines the Continuous Integration (CI) setup for the release-9.0-beta.2 branch. It integrates new comprehensive integration tests for TiCDC's various components (Kafka, Pulsar, Storage), ensures existing critical tests are always executed, and improves the flexibility of binary fetching in test pipelines. Additionally, it cleans up obsolete test configurations, streamlining the CI process for this new release branch.
Highlights
- New CI Job Definitions: Introduced new Jenkins pipeline job definitions for TiCDC's Kafka (heavy and light), Pulsar (light), and Storage (heavy and light) integration tests specifically for the
release-9.0-betabranch. These jobs are configured to run automatically as presubmit checks. - Kubernetes Pod Template Additions: Added corresponding Kubernetes Pod template YAML files for the newly introduced TiCDC integration tests, defining the necessary containers, resources, and environment for each test type.
- Dynamic Branch Resolution for Binaries: Updated existing TiCDC MySQL integration test pipelines (
pull_cdc_mysql_integration_heavy.groovy,pull_cdc_mysql_integration_light.groovy) and TiFlow DM compatibility/integration tests (pull_dm_compatibility_test.groovy,pull_dm_integration_test.groovy) to dynamically fetch third-party binaries based on theREFS.base_refinstead of a hardcoded branch name (e.g.,release-9.0-beta.1). This ensures tests pull binaries relevant to the current base branch. - Mandatory Integration Tests: Changed the
pull-cdc-mysql-integration-lightandpull-cdc-mysql-integration-heavypresubmit jobs from optional to mandatory, ensuring these critical tests always run before merging. - Obsolete Job Removal/Disabling: Disabled the
pull_tiflash_testJenkins job for therelease-9.0-betabranch and removed its corresponding presubmit job definition from Prow, aligning with its removal from the master branch.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request adds CI job configurations for the new release-9.0-beta.2 branch, including Jenkins job definitions, pipeline scripts, pod specifications, and updates to Prow presubmit configurations. There's a critical bug in one of the pipeline scripts, and some Docker images are not using specific tags.
| def tidbBranch = component.computeBranchFromPR('tidb', REFS.base_ref, REFS.pulls[0].title, 'REFS.base_ref') | ||
| def pdBranch = component.computeBranchFromPR('pd', REFS.base_ref, REFS.pulls[0].title, 'REFS.base_ref') | ||
| def tikvBranch = component.computeBranchFromPR('tikv', REFS.base_ref, REFS.pulls[0].title, 'REFS.base_ref') | ||
| def tiflashBranch = component.computeBranchFromPR('tiflash', REFS.base_ref, REFS.pulls[0].title, 'REFS.base_ref') |
There was a problem hiding this comment.
The component.computeBranchFromPR calls are using 'REFS.base_ref' as a string literal for the default branch, instead of using the REFS.base_ref variable. Remove the single quotes around REFS.base_ref.
def tidbBranch = component.computeBranchFromPR('tidb', REFS.base_ref, REFS.pulls[0].title, REFS.base_ref)
def pdBranch = component.computeBranchFromPR('pd', REFS.base_ref, REFS.pulls[0].title, REFS.base_ref)
def tikvBranch = component.computeBranchFromPR('tikv', REFS.base_ref, REFS.pulls[0].title, REFS.base_ref)
def tiflashBranch = component.computeBranchFromPR('tiflash', REFS.base_ref, REFS.pulls[0].title, REFS.base_ref)
There was a problem hiding this comment.
should be fix in anther PR ASAP.
pipelines/pingcap/ticdc/release-9.0-beta/pod-pull_cdc_kafka_integration_heavy.yaml
Show resolved
Hide resolved
pipelines/pingcap/ticdc/release-9.0-beta/pod-pull_cdc_kafka_integration_light.yaml
Show resolved
Hide resolved
pipelines/pingcap/ticdc/release-9.0-beta/pod-pull_cdc_pulsar_integration_light.yaml
Show resolved
Hide resolved
pipelines/pingcap/ticdc/release-9.0-beta/pod-pull_cdc_storage_integration_heavy.yaml
Show resolved
Hide resolved
pipelines/pingcap/ticdc/release-9.0-beta/pod-pull_cdc_storage_integration_light.yaml
Show resolved
Hide resolved
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wuhuizuo The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
support ci on new branch release9.0-beta.2