Skip to content

[CD] enhance tekton trigger template - 1 #3769

@wuhuizuo

Description

@wuhuizuo

critical

This template provides workspaces for both Linux (cargo-home, cypress-cache) and Darwin (mac-ssh-credentials) platforms unconditionally. This will cause pipeline runs to fail. When os=linux, the pingcap-build-package-linux pipeline will be used, which does not define the mac-ssh-credentials workspace. Similarly, when os=darwin, the pingcap-build-package-darwin pipeline will be used, which does not define cargo-home or cypress-cache. Providing a workspace to a PipelineRun that is not declared in the Pipeline is a fatal error in Tekton.

To fix this, you could:

  1. Split this into two separate templates, one for Linux and one for Darwin, each with the correct workspaces.
  2. Modify the underlying pingcap-build-package-linux and pingcap-build-package-darwin pipelines to declare all these workspaces as optional. However, this might make the pipelines less clear.

Originally posted by @gemini-code-assist[bot] in #3768 (comment)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    Status

    📋 Backlog

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions