Api(client): 아티클 수정 API 연결 #97
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -13,22 +13,38 @@ import { | |
| validateTime, | ||
| } from '@pinback/design-system/ui'; | ||
| import { cn } from '@pinback/design-system/utils'; | ||
| import { | ||
| useGetDashboardCategories, | ||
| usePutEditArticle, | ||
| } from '@shared/apis/queries'; | ||
| import { usePageMeta } from '@shared/hooks/usePageMeta'; | ||
| import { ArticleDetailResponse, EditArticleRequest } from '@shared/types/api'; | ||
| import { updateDate, updateTime } from '@shared/utils/formatDateTime'; | ||
| import { useQueryClient } from '@tanstack/react-query'; | ||
| import { useEffect, useState } from 'react'; | ||
|
|
||
| export interface CardEditModalProps { | ||
| onClose: () => void; | ||
| prevData: ArticleDetailResponse | undefined; | ||
| } | ||
|
|
||
| export default function CardEditModal({ | ||
| onClose, | ||
| prevData, | ||
| }: CardEditModalProps) { | ||
| const { meta } = usePageMeta( | ||
| 'https://www.notion.so/PinBack-23927450eb1c8080a5a1f84a9d483aa9' | ||
| ); | ||
| const { data: category } = useGetDashboardCategories(); | ||
| const { mutate: editArticle } = usePutEditArticle(); | ||
| const queryClient = useQueryClient(); | ||
|
|
||
| const [isRemindOn, setIsRemindOn] = useState(false); | ||
| const [selectedCategory, setSelectedCategory] = useState<string | null>(null); | ||
| const [isPopupOpen, setIsPopupOpen] = useState(false); | ||
coderabbitai[bot] marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| // 입력 필드 상태: 서버에서 받아올 데이터 | ||
| const [memo, setMemo] = useState(''); | ||
| const [categoryTitle, setCategoryTitle] = useState(''); | ||
| const [date, setDate] = useState(''); | ||
| const [time, setTime] = useState(''); | ||
|
|
@@ -62,6 +78,64 @@ export default function CardEditModal({ onClose }: CardEditModalProps) { | |
| setIsRemindOn(checked); | ||
| }; | ||
|
|
||
| const saveData = () => { | ||
| if (!prevData?.id) { | ||
| console.error('Article ID is missing, cannot save.'); | ||
| setToastIsOpen(true); | ||
| return; | ||
| } | ||
|
|
||
| const editArticleData: EditArticleRequest = { | ||
| memo, | ||
| categoryId: | ||
| category?.categories.find((cat) => cat.name === selectedCategory)?.id || | ||
| -1, | ||
| now: new Date().toISOString(), | ||
| remindTime: isRemindOn ? `${date}T${time}` : null, | ||
| }; | ||
|
|
||
| editArticle( | ||
| { | ||
| articleId: prevData?.id, | ||
| editArticleData, | ||
| }, | ||
| { | ||
| onSuccess: () => { | ||
| queryClient.invalidateQueries({ | ||
| queryKey: ['remindArticles'], | ||
| }); | ||
| queryClient.invalidateQueries({ | ||
| queryKey: ['bookmarkReadArticles'], | ||
| }); | ||
| queryClient.invalidateQueries({ | ||
| queryKey: ['bookmarkUnreadArticles'], | ||
| }); | ||
| queryClient.invalidateQueries({ | ||
| queryKey: ['categoryBookmarkArticles'], | ||
| }); | ||
| onClose(); | ||
| }, | ||
| onError: () => { | ||
| setToastIsOpen(true); | ||
| }, | ||
| } | ||
| ); | ||
| }; | ||
|
|
||
| useEffect(() => { | ||
| if (prevData) { | ||
| setMemo(prevData.memo || ''); | ||
| setSelectedCategory(prevData.categoryResponse.categoryName || null); | ||
|
|
||
| if (prevData.remindAt) { | ||
| const [rawDate, rawTime] = prevData.remindAt.split('T'); | ||
| setDate(updateDate(rawDate)); | ||
| setTime(updateTime(rawTime)); | ||
| setIsRemindOn(true); | ||
| } | ||
| } | ||
| }, [prevData]); | ||
|
|
||
| return ( | ||
| <div className="flex flex-col"> | ||
| <div | ||
|
|
@@ -101,16 +175,21 @@ export default function CardEditModal({ onClose }: CardEditModalProps) { | |
| </button> | ||
| </header> | ||
|
|
||
| <InfoBox | ||
| title={meta.title} | ||
| source={meta.description} | ||
| imgUrl={meta.imgUrl} | ||
| /> | ||
|
|
||
| <section className="flex flex-col gap-[0.8rem]"> | ||
| <p className="caption1-sb text-font-black-1">카테고리</p> | ||
| <Dropdown | ||
| options={ | ||
| category?.categories.map((category) => category.name) || [] | ||
| } | ||
| selectedValue={selectedCategory} | ||
| onChange={(value) => setSelectedCategory(value)} | ||
| placeholder="선택해주세요" | ||
| addItemLabel="추가하기" | ||
| /> | ||
| </section> | ||
|
|
@@ -151,7 +230,7 @@ export default function CardEditModal({ onClose }: CardEditModalProps) { | |
| {timeError && <p className="body3-r text-error">{timeError}</p>} | ||
| </section> | ||
| {/* TODO: onClick 추후 저장 api 연결후 실패/성공 연결 */} | ||
| <Button onClick={saveData}>저장하기</Button> | ||
| </div> | ||
| {toastIsOpen && ( | ||
| <div className="absolute bottom-[2.4rem] left-1/2 -translate-x-1/2"> | ||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
쿼리 키에 readStatus 파라미터 추가 권장
readStatus파라미터가 함수 시그니처에 추가되었지만, 쿼리 키에는 반영되지 않았습니다. 이로 인해readStatus가 변경되어도 캐시가 무효화되지 않을 수 있습니다.다음과 같이 수정을 권장합니다:
export const useGetCategoryBookmarkArticles = ( categoryId: string | null, readStatus: boolean, page: number, size: number ): UseQueryResult<CategoryBookmarkArticleResponse, AxiosError> => { return useQuery({ - queryKey: ['categoryBookmarkArticles', categoryId, page, size], + queryKey: ['categoryBookmarkArticles', categoryId, readStatus, page, size], queryFn: () => getCategoryBookmarkArticles(categoryId, readStatus, page, size), enabled: !!categoryId, }); };📝 Committable suggestion
🤖 Prompt for AI Agents