feat(aws): add DeployedBy and CloudyPadInstance tags to all resources#365
Open
alexjurkiewicz wants to merge 4 commits into
Open
feat(aws): add DeployedBy and CloudyPadInstance tags to all resources#365alexjurkiewicz wants to merge 4 commits into
alexjurkiewicz wants to merge 4 commits into
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
alexjurkiewicz
commented
Apr 3, 2026
| super("crafteo:cloudypad:aws:base-image", name, args, opts) | ||
|
|
||
| const globalTags = pulumi.all([args.additionalTags]).apply(([tags]) => [ | ||
| name, |
Contributor
Author
There was a problem hiding this comment.
This was creating tags like myinstance=myinstance 🫠
alexjurkiewicz
commented
Apr 3, 2026
|
|
||
| const stack = await this.getStack() | ||
| await stack.setConfig("aws:region", { value: config.region}) | ||
| await stack.setConfig("additionalTags", { value: JSON.stringify([`instance:${config.instanceName}`])}) |
Contributor
Author
There was a problem hiding this comment.
I know you run a SaaS for CloudyPad. You might have stuff which assumes instance tags exist. If so, we can always keep this tag as-is.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DeployedBy=cloudypadandCloudyPadInstance=<name>tags to all AWS resources in all three Pulumi stacks (main, base image snapshot, data disk snapshot)instance=<name>tag on snapshot resources toCloudyPadInstance=<name>for consistencyDetails
The main stack's
CloudyPadEC2Instancecomponent already accepted anargs.tagsmap that was spread into every resource's tags — it just wasn't being populated. This change passescloudypadTagsinto the component at creation time.The snapshot stacks used an
additionalTagsstring-array mechanism withinstance:<name>format. These are updated to useCloudyPadInstance:<name>and addDeployedBy:cloudypad.Test plan
DeployedBy=cloudypadandCloudyPadInstance=<name>tags in the AWS console🤖 Generated with Claude Code