Skip to content

Commit

Permalink
ALSA: emux: Adjust four checks for null pointers
Browse files Browse the repository at this point in the history
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

The script “checkpatch.pl” pointed information out like the following.

Comparison to NULL could be written !…

Thus fix affected source code places.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
  • Loading branch information
elfring authored and tiwai committed Aug 10, 2017
1 parent 949a0c2 commit fbc020b
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions sound/synth/emux/emux_seq.c
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ snd_emux_init_seq(struct snd_emux *emu, struct snd_card *card, int index)
sprintf(tmpname, "%s Port %d", emu->name, i);
p = snd_emux_create_port(emu, tmpname, MIDI_CHANNELS,
0, &pinfo);
if (p == NULL) {
if (!p) {
snd_printk(KERN_ERR "can't create port\n");
return -ENOMEM;
}
Expand Down Expand Up @@ -151,7 +151,7 @@ snd_emux_create_port(struct snd_emux *emu, char *name,
}
p->chset.channels = kcalloc(max_channels, sizeof(*p->chset.channels),
GFP_KERNEL);
if (p->chset.channels == NULL) {
if (!p->chset.channels) {
snd_printk(KERN_ERR "no memory\n");
kfree(p);
return NULL;
Expand Down Expand Up @@ -373,7 +373,7 @@ int snd_emux_init_virmidi(struct snd_emux *emu, struct snd_card *card)
return 0;

emu->vmidi = kcalloc(emu->midi_ports, sizeof(*emu->vmidi), GFP_KERNEL);
if (emu->vmidi == NULL)
if (!emu->vmidi)
return -ENOMEM;

for (i = 0; i < emu->midi_ports; i++) {
Expand Down Expand Up @@ -405,7 +405,7 @@ int snd_emux_delete_virmidi(struct snd_emux *emu)
{
int i;

if (emu->vmidi == NULL)
if (!emu->vmidi)
return 0;

for (i = 0; i < emu->midi_ports; i++) {
Expand Down

0 comments on commit fbc020b

Please sign in to comment.