MOB-76 Update logic for exporting copies for JS

[pankajvaghela]

Update logic for exporting copies for JS

Before copies were exported as 1-on-1 mapping like :

{
  "Basket.EditBasket.AddToDeliveryCurrentDeliverySection.Subtitle.COPY": "%1$s Produkte",
   //...
}

With this change, copies will be exported as JSON object :

{
  "Basket": {
    "EditBasket": {
      "AddToDeliveryCurrentDeliverySection": {
        "Subtitle": {
          "COPY": "%1$s Produkt"
        },
     }
   }
}

JIRA Ticket :
https://picnic.atlassian.net/browse/MOB-76

[pooyahrtn]

A nit, shouldn't it be lowercase?

[pooyahrtn]

Instead of postTemplateRenderFormatting can we rename it to something indicating what this function does? something like unflattenJson or something.

[pankajvaghela]

Then it's very specific. In this function, we could be doing different things based on output mode,

[pooyahrtn]

we could be doing different things based on output mode

Then probably it's against the "single responsibility" principle :D

[pankajvaghela]

Ain't it single resposibility, If the responsibility is "postProcessing", whatever that means, based on outputType? o_O

[LcTwisk]

I agree with @pooyahrtn, let's be explicit about what the function is doing. If we ever need more complicated post-processing steps, we can always change the function name later on.

[pooyahrtn]

I'd say the previous name wasn't that bad, and I would rather keep it to make it easier later to read the git changes.

[pankajvaghela]

For these lines, outType (in global scope) & outType (in local scope) is confusing. That's why changed it to this.
Also if you see other objects in this file, they're plural.

• https://github.com/PicnicSupermarket/localicious/pull/63/files#diff-c944d67b8483c76bf55d7fbb521e2c06bb44c33876b94593b4ce972d7e4c331bR29-R31
• https://github.com/PicnicSupermarket/localicious/pull/63/files#diff-c944d67b8483c76bf55d7fbb521e2c06bb44c33876b94593b4ce972d7e4c331bR68-R70

[LcTwisk]

I agree with @pooyahrtn, let's be explicit about what the function is doing. If we ever need more complicated post-processing steps, we can always change the function name later on.