Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce assorted Reactor StepVerifier Refaster rules #1132

Merged
merged 9 commits into from
Nov 11, 2024
Merged

Introduce assorted Reactor StepVerifier Refaster rules #1132

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
1af4645
Introduce `StepVerifierVerifyLater` Refaster rule
werli Apr 11, 2024
c93356e
Introduce `StepVerifierVerify{,Duration}` Refaster rule
werli Apr 11, 2024
3fbd08b
Introduce `StepVerifierLastStepVerifyErrorSatisfiesAssertJ` Refaster …
werli Apr 11, 2024
bb6f51a
Introduce `StepVerifierLastStepVerifyErrorMatchesAssertions` Refaster…
werli Apr 11, 2024
62d4f7e
Run `./apply-error-prone-suggestions.sh`
werli Apr 12, 2024
55528aa
Suggestions
Stephan202 Apr 12, 2024
f82c671
Indicate that a subset of these rules have breaking behavior
werli Nov 1, 2024
f2830a5
Write down current thinking
Stephan202 Nov 3, 2024
cee4b2c
Doh!
Stephan202 Nov 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Run ./apply-error-prone-suggestions.sh 
Nice
  • Loading branch information
@werli @Stephan202
werli authored and Stephan202 committed Nov 11, 2024
commit 62d4f7eb0f2090ab055cfc225620b226b3dcc484
4 changes: 1 addition & 3 deletions error-prone-contrib/src/main/java/tech/picnic/errorprone/refasterrules/ReactorRules.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,6 @@
import java.util.function.Supplier;
import java.util.stream.Collector;
import java.util.stream.Stream;
import org.assertj.core.api.Assertions;
import org.jspecify.annotations.Nullable;
import org.reactivestreams.Publisher;
import reactor.core.publisher.Flux;
Expand Down Expand Up @@ -1971,8 +1970,7 @@ void before(StepVerifier.LastStep step, Class<? extends Throwable> clazz, String
@AfterTemplate
@UseImportPolicy(STATIC_IMPORT_ALWAYS)
void after(StepVerifier.LastStep step, Class<? extends Throwable> clazz, String message) {
step.verifyErrorSatisfies(
t -> Assertions.assertThat(t).isInstanceOf(clazz).hasMessage(message));
step.verifyErrorSatisfies(t -> assertThat(t).isInstanceOf(clazz).hasMessage(message));
}
}

Expand Down