Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce DuplicateAnnotationAttributeListing #1070

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mohamedsamehsalah
Copy link
Contributor

@mohamedsamehsalah mohamedsamehsalah commented Mar 9, 2024

#1044

Suggested commit message 🎉

Introduce `DuplicateAnnotationAttributeListing` bug checker

@mohamedsamehsalah mohamedsamehsalah added this to the 0.17.0 milestone Mar 9, 2024
@mohamedsamehsalah mohamedsamehsalah linked an issue Mar 9, 2024 that may be closed by this pull request
4 tasks
@mohamedsamehsalah mohamedsamehsalah force-pushed the mohamedsamehsalah/1044-introduce-duplicateannotationlisting-bug-checker-1 branch from 3498b54 to 1734b84 Compare March 9, 2024 21:15
Copy link

github-actions bot commented Mar 9, 2024

  • Surviving mutants in this change: 8
  • Killed mutants in this change: 35
class surviving killed
🧟tech.picnic.errorprone.bugpatterns.DuplicateAnnotationAttributeListing$1 4 8
🧟tech.picnic.errorprone.bugpatterns.DuplicateAnnotationAttributeListing 4 27

Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@mohamedsamehsalah mohamedsamehsalah force-pushed the mohamedsamehsalah/1044-introduce-duplicateannotationlisting-bug-checker-1 branch from 1734b84 to 3f3ae86 Compare March 9, 2024 21:23
Copy link

github-actions bot commented Mar 9, 2024

  • Surviving mutants in this change: 8
  • Killed mutants in this change: 35
class surviving killed
🧟tech.picnic.errorprone.bugpatterns.DuplicateAnnotationAttributeListing$1 4 8
🧟tech.picnic.errorprone.bugpatterns.DuplicateAnnotationAttributeListing 4 27

Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

Copy link

Copy link

  • Surviving mutants in this change: 8
  • Killed mutants in this change: 43
class surviving killed
🧟tech.picnic.errorprone.bugpatterns.DuplicateAnnotationAttributeListing$1 4 8
🧟tech.picnic.errorprone.bugpatterns.DuplicateAnnotationAttributeListing 4 35

Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

* listings of each nested annotation will be the visited through the {@link
* AnnotationTreeMatcher}.
*/
private static ImmutableSet<Tree> getNonDuplicateEntries(
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In theory, this method will flag duplicates of different types with the same name. In practice, that should not happen since listings are of the same type.

@Stephan202 Stephan202 modified the milestones: 0.17.0, 0.18.0 Jul 20, 2024
@rickie rickie modified the milestones: 0.18.0, 0.19.0 Aug 7, 2024
@rickie rickie modified the milestones: 0.19.0, 0.20.0 Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Introduce DuplicateAnnotationListing bug checker
3 participants