Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade fmt-maven-plugin 2.22.1 -> 2.24 #1069

Merged
merged 3 commits into from
Sep 3, 2024

Conversation

Picnic-Bot
Copy link
Contributor

This PR contains the following updates:

Package Type Update Change
fmt-maven-plugin build minor 2.22.1 -> 2.23

Release Notes

spotify/fmt-maven-plugin (fmt-maven-plugin)

v2.23

Compare Source


  • If you want to rebase/retry this PR, check this box

@Picnic-Bot
Copy link
Contributor Author

Picnic-Bot commented Mar 8, 2024

Suggested commit message:

Upgrade fmt-maven-plugin 2.22.1 -> 2.24 (#1069)

See:
- https://github.com/spotify/fmt-maven-plugin/releases/tag/2.23
- https://github.com/spotify/fmt-maven-plugin/releases/tag/2.24
- https://github.com/spotify/fmt-maven-plugin/compare/2.22.1...2.24

Copy link

github-actions bot commented Mar 8, 2024

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@Stephan202 Stephan202 added this to the 0.16.0 milestone Mar 8, 2024
Copy link
Member

@Stephan202 Stephan202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Release notes not yet available, but updated the suggested commit message anyway.

I also pushed a formatting change suggested by GJF, but it looks off; we may want to flag this upstream.

Copy link

github-actions bot commented Mar 8, 2024

Looks good. All 1 mutations in this change were killed.

class surviving killed
🎉tech.picnic.errorprone.refaster.test.RefasterRuleCollection$UnexpectedMatchReporter 0 1

Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

Copy link

sonarqubecloud bot commented Mar 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@Stephan202
Copy link
Member

I also pushed a formatting change suggested by GJF, but it looks off; we may want to flag this upstream.

I filed google/google-java-format#1081.

@rickie rickie modified the milestones: 0.16.0, 0.17.0 Mar 8, 2024
@Picnic-Bot
Copy link
Contributor Author

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

@Stephan202
Copy link
Member

I also pushed a formatting change suggested by GJF, but it looks off; we may want to flag this upstream.

I filed google/google-java-format#1081.

A fix for this issue was released; I filed spotify/fmt-maven-plugin#190 to update the plugin.

@Stephan202 Stephan202 modified the milestones: 0.17.0, 0.18.0 Jul 20, 2024
@Stephan202 Stephan202 force-pushed the renovate/fmt-maven-plugin-2.x branch from a2196ee to 2ede2a1 Compare August 4, 2024 10:38
Copy link

github-actions bot commented Aug 4, 2024

Looks good. All 1 mutations in this change were killed.

class surviving killed
🎉tech.picnic.errorprone.refaster.test.RefasterRuleCollection$UnexpectedMatchReporter 0 1

Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@rickie rickie modified the milestones: 0.18.0, 0.19.0 Aug 7, 2024
@Stephan202 Stephan202 force-pushed the renovate/fmt-maven-plugin-2.x branch from 2ede2a1 to 1e9440f Compare August 23, 2024 20:16
@Stephan202 Stephan202 changed the title Upgrade fmt-maven-plugin 2.22.1 -> 2.23 Upgrade fmt-maven-plugin 2.22.1 -> 2.24 Aug 23, 2024
Copy link
Member

@Stephan202 Stephan202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebased branch, upgraded plugin and updated the suggested commit message. @rickie this PR is now ready to go.

Copy link

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@rickie rickie force-pushed the renovate/fmt-maven-plugin-2.x branch from 1e9440f to 5c44e88 Compare August 27, 2024 13:49
Copy link

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@rickie rickie force-pushed the renovate/fmt-maven-plugin-2.x branch from 5c44e88 to 8256f96 Compare August 28, 2024 07:32
Copy link

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@Stephan202 Stephan202 force-pushed the renovate/fmt-maven-plugin-2.x branch from 8256f96 to df5e4ad Compare August 31, 2024 16:12
Copy link

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@Stephan202
Copy link
Member

The build now fails because Jitpack again lost some artifacts. I'll try to prioritize #1314, as that would be the cleanest way to move forward.

@rickie rickie force-pushed the renovate/fmt-maven-plugin-2.x branch from df5e4ad to 643fce3 Compare September 3, 2024 10:19
@rickie
Copy link
Member

rickie commented Sep 3, 2024

Makes sense, rebased!

Copy link

sonarqubecloud bot commented Sep 3, 2024

Copy link

github-actions bot commented Sep 3, 2024

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@Stephan202 Stephan202 merged commit e4f928a into master Sep 3, 2024
16 checks passed
@Stephan202 Stephan202 deleted the renovate/fmt-maven-plugin-2.x branch September 3, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants