Improve error handling when dbt manifest is not found #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| "dbt's manifest.json could not be found. If you're in a dbt project, be " | ||
| "sure to run 'dbt parse' first, or use the option '--run-dbt-parse'." | ||
| ) | ||
| ctx.exit(2) |
There was a problem hiding this comment.
Could you elaborate a little bit on this? Why not just raising an error for example?
There was a problem hiding this comment.
Yes, the idea is to improve the UX, and not confuse users with a stacktrace they don't care about, but rather a more helpful message
There was a problem hiding this comment.
That's fair, thanks!
jochemvandooren
approved these changes
May 27, 2024
Yesss my bad, it's fixed now :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.