Added option to join OpenGolfSim, Camera Saturation changes#172
Open
Sunnyland wants to merge 1 commit intoPiTracLM:mainfrom
Open
Added option to join OpenGolfSim, Camera Saturation changes#172Sunnyland wants to merge 1 commit intoPiTracLM:mainfrom
Sunnyland wants to merge 1 commit intoPiTracLM:mainfrom
Conversation
Sunnyland
requested review from
connorgallopo and
jamespilgrim
as code owners
Contributor
|
Thanks for your PR! Before we can review it, please sign our Contributor License Agreement. How to sign (right here in this PR):
|
connorgallopo
requested changes
Jan 20, 2026
Collaborator
connorgallopo
left a comment
connorgallopo
left a comment
There was a problem hiding this comment.
Need to pull and test / do another functional review pass - overall it looks solid just needs some cleanup!
| SetConstant("gs_config.cameras.kCamera2Gain", LibCameraInterface::kCamera2Gain); | ||
| SetConstant("gs_config.cameras.kCamera2Saturation", LibCameraInterface::kCamera2Saturation); | ||
|
|
||
| SetConstant("gs_config.comeras.kCamera2Saturations", LibCameraInterface::kCamera2Saturation); |
Comment on lines
+63
to
+64
| SetConnectionState(SimConnState::kConnecting); | ||
| GS_LOG_MSG(info, "Connecting to SimSocketServer at: " + socket_connect_address_ + ":" + socket_connect_port_); |
| else { | ||
| if (!GolfSimOptions::GetCommandLineOptions().lm_comparison_mode_) { | ||
| options->gain = LibCameraInterface::kCamera2Gain; | ||
| options->saturation = (float)LibCameraInterface::kCamera2Saturation; |
| static double kCamera1Contrast; // 0.0 to 32.0 | ||
| static double kCamera2Gain; // 0.0 to TBD?? | ||
| static double kCamera2Saturation; | ||
| static double kCamera2Saturation; //0.0 = greyscale, 1.0 = normal |
Comment on lines
+219
to
+220
| 'gs_opengolfsim_interface.cpp', | ||
| 'gs_opengolfsim_results.cpp' |
| # Dev scripts cache | ||
| Dev/scripts/__pycache__ | ||
| packaging/pitrac | ||
| *.save |
Collaborator
|
It also looks like your branch is 12 commits behind HEAD - let me know if you need help rebasing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added Saturation and to config. default set to 0, although James has already done this with a default to 1.
Added new Simulator - OpenGolfSim - https://opengolfsim.com/ A free golf sim with a practice range and 9 hole golf course.
Early stages of checking Simulator connection during start up.
Testing Performed
Test Environment
Test Results
pitrac test hardwarepassespitrac test camerapasses (if camera-related)pitrac test pulsepasses (if strobe-related)Hardware Compatibility
Documentation
Screenshots/Videos
Checklist
Code Quality
Build & Test
./packaging/build.sh buildSubmission Requirements
git rebase -i HEAD~n)[PR TYPE] Brief descriptionAdditional Context