[examples] Re-organize simaimandrange #937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcm001
reviewed
Oct 9, 2023
photonlib-java-examples/simaimandrange/src/main/java/frc/robot/Constants.java
Outdated
Show resolved
Hide resolved
mcm001
reviewed
Oct 9, 2023
photonlib-java-examples/simaimandrange/src/main/java/frc/robot/Robot.java
Show resolved
Hide resolved
mdurrani808
reviewed
Oct 9, 2023
photonlib-java-examples/simaimandrange/src/main/java/frc/robot/Constants.java
Outdated
Show resolved
Hide resolved
photonlib-java-examples/simaimandrange/src/main/java/frc/robot/Constants.java
Outdated
Show resolved
Hide resolved
| new Translation3d(0, Units.inchesToMeters(19.625), Units.inchesToMeters(8.5)), | ||
| new Translation3d(0, Units.inchesToMeters(-19.625), Units.inchesToMeters(8.5)))); | ||
|
|
||
| // Simulated camera properties. These can be set to mimic your actual camera. |
There was a problem hiding this comment.
do all of these need to be set or can the user only set some of them? what are some good defaults for these values / how can the user find them
There was a problem hiding this comment.
These are set to a "perfect" 960x720 90 deg FOV camera without lag or noise by default. There are also static example fields for reference. It will be explained in the docs simulation page/example walkthrough.
mcm001
approved these changes
Oct 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-organizes simaimandrange example to make it cleaner to walkthrough.