Skip to content

Conversation

@thatcomputerguy0101
Copy link
Contributor

@thatcomputerguy0101 thatcomputerguy0101 commented Jan 11, 2026

Description

This adds support for other styles of status LEDs, starting with the Limelight Green-Yellow LEDs. LED indication was designed to match Limelight's as closely as possible within the limitation of PhotonVision's statuses. Additionally, I created a new documentation page explaining what the colors mean for both the RGB and the Green-Yellow status LED types.

IMG_1900.mov

For a future PR, I think it would be reasonable to implement addressable LED support, using the same colors as the regular RGB LED.

Meta

Merge checklist:

  • Pull Request title is short, imperative summary of proposed changes
  • The description documents the what and why
  • If this PR changes behavior or adds a feature, user documentation is updated
  • If this PR touches photon-serde, all messages have been regenerated and hashes have not changed unexpectedly
  • If this PR touches configuration, this is backwards compatible with settings back to v2025.3.2
  • If this PR touches pipeline settings or anything related to data exchange, the frontend typing is updated
  • If this PR addresses a bug, a regression test for it is added

@github-actions github-actions bot added documentation Anything relating to https://docs.photonvision.org backend Things relating to photon-core and photon-server labels Jan 11, 2026
@thatcomputerguy0101
Copy link
Contributor Author

I should probably also add a documentation section explaining the different color combinations.

Comment on lines +77 to +79
case GENERIC_ERROR ->
// No lights
setLEDs(false, false);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am debating between no lights and a slow green blink with no yellow. There is no precedent from Limelight on this case.

@thatcomputerguy0101
Copy link
Contributor Author

My hardware cooperated, and I confirmed everything here works as expected.

IMG_1900.mov

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With more LED support added to these hardware configuration files, I'm not sure hidden in the documentation is the best spot for them anymore. It feels more appropriate to install them in the images available for download, like is done for Luma P1. However, I'm also not sure if I like the sqlite database being committed for just hardware config, since it is a lot harder to view the contents of a sqlite than it is for JSON.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Absolutely agree. Maybe for 27. Let's talk about committing Jason files but converting them using some sort of Java tool?

@thatcomputerguy0101 thatcomputerguy0101 force-pushed the limelight-leds branch 2 times, most recently from 7327e6f to 10357f5 Compare January 16, 2026 16:22
@thatcomputerguy0101
Copy link
Contributor Author

Documentation has been added, although the LED animations may be a little jank due to the weird interactions between MyST, Sphinx, Docutils, HTML, and SVG.

@thatcomputerguy0101
Copy link
Contributor Author

There is the sphinx-contrib/imagesvg package that would eliminate the need for the zero-height image, but it doesn't support passing params around.

@thatcomputerguy0101 thatcomputerguy0101 marked this pull request as ready for review January 20, 2026 00:15
@thatcomputerguy0101 thatcomputerguy0101 requested review from a team as code owners January 20, 2026 00:15
@thatcomputerguy0101 thatcomputerguy0101 changed the title Add support for LL-style status LEDs Add support for Green/Yellow status LEDs, like is used on some Limelights Jan 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend Things relating to photon-core and photon-server documentation Anything relating to https://docs.photonvision.org

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants