-
Notifications
You must be signed in to change notification settings - Fork 281
Add support for Green/Yellow status LEDs, like is used on some Limelights #2287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add support for Green/Yellow status LEDs, like is used on some Limelights #2287
Conversation
25f0ccc to
d2055ab
Compare
photon-core/src/main/java/org/photonvision/common/hardware/statusLED/StatusLEDType.java
Outdated
Show resolved
Hide resolved
d2055ab to
0f1eba1
Compare
|
I should probably also add a documentation section explaining the different color combinations. |
| case GENERIC_ERROR -> | ||
| // No lights | ||
| setLEDs(false, false); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am debating between no lights and a slow green blink with no yellow. There is no precedent from Limelight on this case.
|
My hardware cooperated, and I confirmed everything here works as expected. IMG_1900.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With more LED support added to these hardware configuration files, I'm not sure hidden in the documentation is the best spot for them anymore. It feels more appropriate to install them in the images available for download, like is done for Luma P1. However, I'm also not sure if I like the sqlite database being committed for just hardware config, since it is a lot harder to view the contents of a sqlite than it is for JSON.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Absolutely agree. Maybe for 27. Let's talk about committing Jason files but converting them using some sort of Java tool?
7327e6f to
10357f5
Compare
10357f5 to
f8602e5
Compare
|
Documentation has been added, although the LED animations may be a little jank due to the weird interactions between MyST, Sphinx, Docutils, HTML, and SVG. |
|
There is the sphinx-contrib/imagesvg package that would eliminate the need for the zero-height image, but it doesn't support passing params around. |
Description
This adds support for other styles of status LEDs, starting with the Limelight Green-Yellow LEDs. LED indication was designed to match Limelight's as closely as possible within the limitation of PhotonVision's statuses. Additionally, I created a new documentation page explaining what the colors mean for both the RGB and the Green-Yellow status LED types.
IMG_1900.mov
For a future PR, I think it would be reasonable to implement addressable LED support, using the same colors as the regular RGB LED.
Meta
Merge checklist: