-
Notifications
You must be signed in to change notification settings - Fork 281
Exit and serve static html message on SystemCore #2170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update stuff I missed
mcm001
reviewed
Oct 31, 2025
Member
Author
616aa21 to
c2c8b13
Compare
7bbda26 to
7d47eea
Compare
Contributor
|
Nobody is using systemcores in 2026. Retarget this at the 2027 branch |
7 tasks
Member
Author
|
Superceded by #2302 since I'm too lazy to fix the git history |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backend
Things relating to photon-core and photon-server
documentation
Anything relating to https://docs.photonvision.org
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Description
Needs to be tested on SC.
Running on SystemCore is bad, as PV tends to be a resource hog. Additionally, if issues arise, it can cause major problems. We want to ensure that a team has to intentionally take actions in order to run PV on SC, thus we serve a static webpage informing teams that SC isn't supported and exit.
Meta
Merge checklist: